[PATCH] Bash completion with elderly bash version

[Alessandro Morgantini]

Hello,
I’m using pass on OS X El Capitan (10.11.6), where bash is quite old:

Mac-di-Ale:~ gpz500$ bash --version 
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
Copyright (C) 2007 Free Software Foundation, Inc.

In such an elderly bash, the builtin command compopt is not present. Unfortunately, compopt is used in two places in bash completion pass file so, every time I press the <Tab> key, I obtain the following message:

Mac-di-Ale:~ gpz500$ pass -bash: compopt: command not found
-bash: compopt: command not found

Logins/   find      grep      insert    rm        
cp        generate  help      ls        show      
edit      git       init      mv        version   

which is very annoying, even if it doesn’t brake the functioning. Well, I’ve modified the bash completion file as in the attached patch which is, in my opinion, quite better (even if, sometimes, I find some extra unwanted space...) and doesn’t break compatibility with bash version >= 4.
What do you think? Could it be pushed?

Cheers,
Alessandro


--
Ing. Alessandro Morgantini - http://www.morgantini.org/
Email: gpz500 at technologist.com
Cell.: +39-347 761 1221 - Fax: +39-390 347 761 1221

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190109/28224e33/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pass.bash-completion.patch
Type: application/octet-stream
Size: 804 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190109/28224e33/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190109/28224e33/attachment-0001.html>