pass generates quite a few errors/warnings with shellcheck

[ಚಿರಾಗ್ ನಟರಾಜ್]

Hey all,

So I did a cursory search for "shellcheck" on the mailing list archives and only found one reference (https://lists.zx2c4.com/pipermail/password-store/2016-December/002568.html) to this and there seemed to be no replies.

The version of pass I have (1.7.3) seems to generate a _ton_ of errors/warnings with shellcheck. I've attached them in JSON format to the email so as to not clutter up the email itself. While many of them are only warnings, it's probably a good idea to tackle some of them.

The one caveat is that I'm not sure how many of them are still relevant with the latest git version - that's something I can check if it's useful.

What are people's thoughts on this?

Sincerely,

Chiraag
-- 
ಚಿರಾಗ್ ನಟರಾಜ್
Graduate Student at Brown University
Email: chiraag.nataraj at gmail.com
Phone: 610-350-6329
Website: http://chiraag.nataraj.us
-------------- next part --------------
[{"file":"/usr/bin/pass","line":9,"endLine":9,"column":12,"endColumn":12,"level":"warning","code":2206,"message":"Quote to prevent word splitting, or split robustly with mapfile or read -a."},{"file":"/usr/bin/pass","line":12,"endLine":12,"column":1,"endColumn":1,"level":"info","code":2230,"message":"which is non-standard. Use builtin 'command -v' instead."},{"file":"/usr/bin/pass","line":61,"endLine":61,"column":15,"endColumn":15,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":61,"endLine":61,"column":36,"endColumn":36,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":109,"endLine":109,"column":15,"endColumn":15,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":109,"endLine":109,"column":30,"endColumn":30,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":121,"endLine":121,"column":39,"endColumn":39,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":126,"endLine":126,"column":42,"endColumn":42,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":128,"endLine":128,"column":47,"endColumn":47,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":132,"endLine":132,"column":136,"endColumn":136,"level":"info","code":2015,"message":"Note that A && B || C is not if-then-else. C may run when A is true."},{"file":"/usr/bin/pass","line":159,"endLine":159,"column":15,"endColumn":15,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":163,"endLine":163,"column":23,"endColumn":23,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":218,"endLine":218,"column":61,"endColumn":61,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":327,"endLine":327,"column":27,"endColumn":27,"level":"style","code":1117,"message":"Backslash is literal in \"\\n\". Prefer explicit escaping: \"\\\\n\"."},{"file":"/usr/bin/pass","line":328,"endLine":328,"column":23,"endColumn":23,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":334,"endLine":334,"column":63,"endColumn":63,"level":"warning","code":2206,"message":"Quote to prevent word splitting, or split robustly with mapfile or read -a."},{"file":"/usr/bin/pass","line":370,"endLine":370,"column":81,"endColumn":81,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":395,"endLine":395,"column":15,"endColumn":15,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":404,"endLine":404,"column":20,"endColumn":20,"level":"style","code":2181,"message":"Check exit code directly with e.g. 'if mycmd;', not indirectly with $?."},{"file":"/usr/bin/pass","line":410,"endLine":410,"column":25,"endColumn":25,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":410,"endLine":410,"column":33,"endColumn":33,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":410,"endLine":410,"column":40,"endColumn":40,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":410,"endLine":410,"column":46,"endColumn":46,"level":"style","code":1117,"message":"Backslash is literal in \"\\n\". Prefer explicit escaping: \"\\\\n\"."},{"file":"/usr/bin/pass","line":475,"endLine":475,"column":15,"endColumn":15,"level":"warning","code":2155,"message":"Declare and assign separately to avoid masking return values."},{"file":"/usr/bin/pass","line":518,"endLine":518,"column":20,"endColumn":20,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":25,"endColumn":25,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":57,"endColumn":57,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":64,"endColumn":64,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":74,"endColumn":74,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":79,"endColumn":79,"level":"style","code":1117,"message":"Backslash is literal in \"\\n\". Prefer explicit escaping: \"\\\\n\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":81,"endColumn":81,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":86,"endColumn":86,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":94,"endColumn":94,"level":"style","code":1117,"message":"Backslash is literal in \"\\e\". Prefer explicit escaping: \"\\\\e\"."},{"file":"/usr/bin/pass","line":540,"endLine":540,"column":99,"endColumn":99,"level":"style","code":1117,"message":"Backslash is literal in \"\\n\". Prefer explicit escaping: \"\\\\n\"."},{"file":"/usr/bin/pass","line":673,"endLine":673,"column":9,"endColumn":9,"level":"warning","code":1090,"message":"Can't follow non-constant source. Use a directive to specify location."}]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190517/26840508/attachment.asc>