[PATCH] pass generates quite a few errors/warnings with shellcheck

[ಚಿರಾಗ್ ನಟರಾಜ್]

Copy that!

I fixed many (but not all) of the warnings. Two we can't _really_ do anything about (the SC1090s) and two I'm not quite sure how to fix. After my modifications, it passes all the tests, which is a good sign, but there's definitely a chance I misinterpreted something in the code.

Sincerely,

Chiraag
-- 
ಚಿರಾಗ್ ನಟರಾಜ್
Graduate Student at Brown University
Email: chiraag.nataraj at gmail.com
Phone: 610-350-6329
Website: http://chiraag.nataraj.us

On 18/05/19 18:33, HacKan wrote:
> Well, you might be better of checking out from master and running
> shellcheck on that source, then commiting a patch :)
> 
> Cheers!
> 
> On 5/17/19 7:18 PM, ಚಿರಾಗ್ ನಟರಾಜ್ wrote:
> > Hey all,
> >
> > So I did a cursory search for "shellcheck" on the mailing list archives and only found one reference (https://lists.zx2c4.com/pipermail/password-store/2016-December/002568.html) to this and there seemed to be no replies.
> >
> > The version of pass I have (1.7.3) seems to generate a _ton_ of errors/warnings with shellcheck. I've attached them in JSON format to the email so as to not clutter up the email itself. While many of them are only warnings, it's probably a good idea to tackle some of them.
> >
> > The one caveat is that I'm not sure how many of them are still relevant with the latest git version - that's something I can check if it's useful.
> >
> > What are people's thoughts on this?
> >
> > Sincerely,
> >
> > Chiraag
> >
> > _______________________________________________
> > Password-Store mailing list
> > Password-Store at lists.zx2c4.com
> > https://lists.zx2c4.com/mailman/listinfo/password-store
> 
> -- 
> HacKan || Iván
> GPG: 0x35710D312FDE468B
> 

> _______________________________________________
> Password-Store mailing list
> Password-Store at lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/password-store

-------------- next part --------------
A non-text attachment was scrubbed...
Name: shellcheck.patch
Type: text/x-diff
Size: 8264 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190518/477a4f29/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190518/477a4f29/attachment.asc>