[PATCH] Allow GETOPT to be set externally to improve performance on macOS

Joe Horsnell password-store at joh.io
Thu Sep 5 21:38:51 CEST 2019


`brew --prefix <formula>` is a relatively slow operation (order of half a
second or more) and this is not considered a bug (see `Homebrew/brew`
issues 3097 and 3327).

The macOS plaform-specific script evaluates `brew --prefix gnu-getopt` each
time `pass` is invoked, which adds a noticeable delay, especially if `pass`
is called a lot of times (eg in a script that iterates over a large number
of entries in a pass store).

This change allows `GETOPT` to be set externally and `pass` will use the
value provided without evaluating the slow `brew` command.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190905/b5076d94/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-GETOPT-to-be-set-externally-to-improve-perform.patch
Type: application/octet-stream
Size: 2190 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20190905/b5076d94/attachment.obj>


More information about the Password-Store mailing list