[PATCH] Honour the $VISUAL environment variable

[Allan Odgaard]

On 19 Jul 2020, at 15:56, password-store at storiepvtride.it wrote:

> I'm a bit confused by the patch intent and the above statement: do I
> read a misplaced "not"? Did you perhaps mean that in your system 
> $EDITOR
> *is* a visual editor? Probably my fault I'm not understanding :-)

I was confused as well: Turns out in this context, a VISUAL editor is 
one that can assume the user is running in a terminal, so it can e.g. 
move to previous lines, unlike a non-visual (line) EDITOR which is 
limited to the current line, because output e.g. goes to a teletype 
(remote printer).

I still don’t really get it though: Why would anyone (today) set 
EDITOR to a line editor *and* then expect programs to use VISUAL over 
EDITOR?

I mean, strictly speaking, if pass were to use both VISUAL and EDITOR, 
it should check that it is running in a terminal, and only then, call 
VISUAL, otherwise call EDITOR. But I think the de facto standard today 
is for people to just set EDITOR to a “visual” editor, as teletypes 
are a thing of the past.

Would love to get this clarified by Pudinha or Nils :)