`pass git` exit code

robpilling at gmail.com robpilling at gmail.com
Sun Jun 28 18:41:05 CEST 2020


On Thu, 25 Jun 2020, Kjetil Torgrim Homme wrote:
> On 6/24/20 10:23 PM, robpilling at gmail.com wrote:
>> That's a fair point - my main reason for doing it this way was that I
>> imagined exiting with the same code as the git command would be more
>> useful, so users can treat `pass git [...]` as a transparent wrapper,
>> particularly for commands that specify specific exit codes. Happy to
>> change it if people would prefer the consistent use of die() / exit code
>> of 1.
>
> I would prefer to keep the information from git exit codes intact as
> well, but this should be documented in the manual page.  I see there is
> no EXIT CODES section today, so there isn't really any documented
> behaviour to break.

Cool - documentation added, also removed two odd-one-out cases of $?.

Thanks,
Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Document-exit-codes.patch
Type: text/x-diff
Size: 775 bytes
Desc: 
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20200628/be036cfd/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Unify-exit-code-for-base64-or-head-failure.patch
Type: text/x-diff
Size: 1283 bytes
Desc: 
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20200628/be036cfd/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Exit-with-git-s-error-code-for-pass-git.patch
Type: text/x-diff
Size: 885 bytes
Desc: 
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20200628/be036cfd/attachment-0002.patch>


More information about the Password-Store mailing list