PATCH: fish-completion: don't print full path when PASSWORD_STORE_DIR is set

Johannes Altmanninger aclopte at gmail.com
Tue May 18 20:59:13 UTC 2021


On Tue, May 18, 2021 at 08:37:42PM +0100, Sam A. Horvath-Hunt wrote:
> Hey Johannes,
> 
> > A workaround is to set $PASSWORD_STORE_DIR without a trailing slash.
> 
> I've not tried the patch, but thanks for the workaround, that works
> great!

just in case anyone needs it, the patch can be test-run by copying
src/completion/pass.fish-completion to
~/.config/fish/completions/pass.fish

> 
> The only thing I'd note is that it's still broken if there's an
> additional slash preceding it. In my case that's because I've defined a
> path in a variable with a trailing slash and then for readability done
> "$MYVAR/subpath", making it effectively "/home/user/path//subpath". I
> don't know if this is relevant to the fix at all.

Right, good catch - we can't expect a canonical path here. I'll send a more
robust version.

Cheers


More information about the Password-Store mailing list