[PATCH] emacs: Add variable password-store-file-extension.

[Tino Calancha]

Dear Nicolas,

Thank you for your contribution and your patience while awaiting a
response. I appreciate your effort in submitting the patch.

I reviewed your patch carefully a few days after it was posted, and I
apologize for not providing any feedback earlier.

However, I am not comfortable with accepting this patch. The reason is
that it may give users the false impression that everything will work
seamlessly with the AGE encryption as it does with GPG. It won't.

Indeed, to fully support AGE encryption at the same level as we do
with GPG would require significant upstream work. Currently, Emacs
ships with the epa- libraries, which are tailored to support GPG and
handle transparent encryption/decryption of files.

Until we have equivalent libraries that can handle AGE encryption, I
discourage adding a patch like the one you proposed.

Thank you again for your contribution, and I apologize for not
providing feedback earlier.

Tino



On Thu, 9 Mar 2023, Nicolas Graves wrote:

>
> Hey,
>
> Sorry to ask again, I didn't get any answer, this is just a simple patch
> adding only one variable, which enables the emacs package to also
> support age as well.
>
> Is there someone responsible for the emacs code with whom I can discuss
> this?
>
> Thanks in advance,
>
>
> On 2022-12-27 13:59, Nicolas Graves wrote:
>
>> Hi !
>>
>> I don't have an answer to this patch, can someone review this?
>>
>> Thanks in advance,
>>
>> Nicolas Graves
>>
>>
>> On 2022-10-13 23:31, Nicolas Graves wrote:
>>
>>> ---
>>>  contrib/emacs/password-store.el | 9 +++++++--
>>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/contrib/emacs/password-store.el b/contrib/emacs/password-store.el
>>> index 6561eb1..72aee3e 100644
>>> --- a/contrib/emacs/password-store.el
>>> +++ b/contrib/emacs/password-store.el
>>> @@ -66,6 +66,9 @@
>>>  (defvar password-store-timeout-timer nil
>>>    "Timer for clearing clipboard.")
>>>
>>> +(defvar password-store-file-extension ".gpg"
>>> +  "File extension to expect in the password store.")
>>> +
>>>  (defun password-store-timeout ()
>>>    "Number of seconds to wait before clearing the password.
>>>
>>> @@ -187,7 +190,8 @@ Nil arguments are ignored.  Output is discarded."
>>>
>>>  (defun password-store--entry-to-file (entry)
>>>    "Return file name corresponding to ENTRY."
>>> -  (concat (expand-file-name entry (password-store-dir)) ".gpg"))
>>> +  (concat (expand-file-name entry (password-store-dir))
>>> +          password-store-file-extension))
>>>
>>>  (defun password-store--file-to-entry (file)
>>>    "Return entry name corresponding to FILE."
>>> @@ -218,7 +222,8 @@ ENTRY is the name of a password-store entry."
>>>      (if (file-directory-p dir)
>>>          (delete-dups
>>>           (mapcar 'password-store--file-to-entry
>>> -                 (directory-files-recursively dir ".+\\.gpg\\'"))))))
>>> +                 (directory-files-recursively
>>> +                  dir (concat ".+\\" password-store-file-extension "\\'")))))))
>>>
>>>  ;;;###autoload
>>>  (defun password-store-edit (entry)
>
> -- 
> Best regards,
> Nicolas Graves
>