Commit “emacs: Avoid double decryption in field and secret access” broke my setup

[Mekeor Melire]

Hello. I'm reposting because my original message was badly
formatted and got no response. If no one responds, let's please
revert the mentioned commit.



Hello. Git commit 3ca13cd8882cae4083c1c478858adbf2e82dd037 from
2025-06-18 broke my setup. To be precise, this part seems to break
it:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 596 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20250818/7cf2cc7b/attachment.bin>
-------------- next part --------------

Now, how does it break my setup? What is my setup? I use GNU/Linux
with Wayland and wlroots based Wayland compositor. I also run an
Emacs daemon. To temporarily put a password in my clipboard, I run
something along these lines:

  emacsclient --create --no-wait \
    --eval "(call-interactively #'password-store-copy)" \
    --eval "(delete-frame)"

I should also mention that I have an Elisp advice overriding
password-store--run-1 without which my setup doesn't work. It
makes sure that `1' is passed as SECONDS argument to
accept-process-output.

This used to work like a charm but with the mentioned commit
active, the password doesn't end up in my clipboard.

I didn't yet properly investigate the reasons. If I would wildly
guess, I'd wonder if it's due to the removal of the invocation of
password-store--run-show in the above mentioned commit
snippet. Because --run-show will call password-store--run-1 which
will call make-process. I'd guess that this means that before the
patch, effectively my Emacs-daemon process was copying the
password; whereas after the commit, effectively the
emacsclient-process is copying. And since the emacsclient-process
dies when its frame is closed, the Wayland clipboard is cleared.

For now, my workaround is to call password-store-copy in an
existing Emacs frame (i.e. one that I won't close until I at least
have pasted the copied password).

I'd be glad if my problem was solved upstream in
password-store.el. Nevertheless, thank you for the commit and all
the development labour.