[PATCH 0/2] wireguard-linux-compat: grsecurity compat patches

Aymeric Fromherz aymeric.fromherz at inria.fr
Sat Dec 11 16:35:04 UTC 2021

Thanks for the heads-up. We were being overly conservative during verification of inline assembly code in Vale, and marked several registers as possibly modified while they were only read.

This is now fixed for fmul, fmul2, fsqr and fsqr2, and will be merged into the master branch of EverCrypt shortly.
In the meantime, the diff for the resulting inline assembly after Vale codegen is available here: https://github.com/project-everest/hacl-star/pull/501/commits/1a71adb40c3f78da16e16975dbb1d4de5adeab8c#diff-5aabe9f6aa87508c9d81d4c9e89eff0b06b1e2aeaf5b04eba51da71c5bea6940


----- Mail original -----
> De: "Jason A. Donenfeld" <Jason at zx2c4.com>
> À: "Mathias Krause" <minipli at grsecurity.net>, "aymeric fromherz" <aymeric.fromherz at inria.fr>
> Cc: "WireGuard mailing list" <wireguard at lists.zx2c4.com>
> Envoyé: Vendredi 10 Décembre 2021 23:58:01
> Objet: Re: [PATCH 0/2] wireguard-linux-compat: grsecurity compat patches

> CC'ing in Aymeric, who's working on Vale's codegen.
> On Thu, Dec 9, 2021 at 8:59 AM Mathias Krause <minipli at grsecurity.net> wrote:
>> Am 08.12.21 um 15:56 schrieb Jason A. Donenfeld:
>> > On Mon, Dec 6, 2021 at 10:00 PM Mathias Krause <minipli at grsecurity.net> wrote:
>> >> Yes, probably, but you're mixing up the two.
>> >
>> > Oh, thanks, right.
>> >
>> > I'll talk to EverCrypt upstream and see.
>> FWIW, 'out' is also wrongly flagged as output operand in fmul() and
>> fmul2(). But making it an input operand needs more surgery, as the
>> operand order changes and this requires some code churn.
> > Mathias

More information about the WireGuard mailing list