[PATCH] wireguard: Kconfig: select CRYPTO_CHACHA_S390
vdronov at redhat.com
Tue Jul 5 12:07:40 UTC 2022
On Tue, Jul 5, 2022 at 3:51 AM Jason A. Donenfeld <Jason at zx2c4.com> wrote:
> On Tue, Jul 05, 2022 at 02:49:19AM +0200, Jason A. Donenfeld wrote:
> > Hi Vladis,
> > On Mon, Jul 04, 2022 at 09:15:35PM +0200, Vladis Dronov wrote:
> > > Select the new implementation of CHACHA20 for S390 when available,
> > > it is faster than the generic software implementation.
> > >
> > > Reported-by: kernel test robot <lkp at intel.com>
> > > Link: https://lore.kernel.org/linux-kernel/202207030630.6SZVkrWffirstname.lastname@example.org/
> > > Signed-off-by: Vladis Dronov <vdronov at redhat.com>
> > > ... skip ...
> > Thanks for the patch. Queued up as:
> > https://git.zx2c4.com/wireguard-linux/commit/?id=1b4ab028730cd00c144eaa51160865504b780961
> > I'll include this in my series to net.git soon.
Thanks a ton, Jason!
> This actually leads to a minor problem:
> WARNING: unmet direct dependencies detected for CRYPTO_CHACHA_S390
> Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=n] && S390 [=y]
> This is of course harmless, since this doesn't *actually* depend on
> CRYPTO_HW. In fact, the dependency on CRYPTO_HW is entirely a mistake
> here that was repeated a few times. I cleaned this up and fixed it in
> this patch:
> So hopefully Herbert will take that for 5.19 and then we'll be all set
Whoa, that's... funny. Honestly, I was always wondering why CRYPTO_CHACHA_S390
and friends live in drivers/crypto/Kconfig. Now I know why. The patch
looks great, thank you.
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer
More information about the WireGuard