[PATCH] compat: Update version to handle sbcreatecontrol() changes

Jason A. Donenfeld Jason at zx2c4.com
Tue Jun 14 19:59:26 UTC 2022


Hi Joesph,

On Tue, Jun 14, 2022 at 04:15:26PM -0300, Joseph Mingrone wrote:
> The sockbuf changes to merge two versions of sbcreatecontrol() into one
> occurred in b46667c63eb7 in the FreeBSD src repository.  The value of
> __FreeBSD_version at the time of that commit was 1400059, so check
> for systems with a version stamp less than 1400059.
> 
> Ideally __FreeBSD_version would have been bumped in b46667c63eb7,
> however it was set to 1400059 53 commits prior in 3a9a9c0ca44e and not
> bumped to 1400060 until 374 commits later in 85d7875d4291.  Thus, this
> is not a perfect solution because CURRENT systems built from 53 possible
> commits that require the adjustment will still fail to build the
> wireguard kernel module.  This is better than checking for systems with
> __FreeBSD_version < 1400057.  In that case, there are 767 different
> commits a CURRENT system may be built from where the module will fail to
> build.

Seems reasonable. Applied, thanks.

Jason


More information about the WireGuard mailing list