From otilibil at eurecom.fr  Thu Aug  1 09:32:25 2024
From: otilibil at eurecom.fr (Ariel Otilibili)
Date: Thu,  1 Aug 2024 11:32:25 +0200
Subject: [PATCH] wireguard-tools: Extracted error message for the sake of
 legibility
In-Reply-To: <20240801093257.2700-2-otilibil@eurecom.fr>
References: <20240801093257.2700-2-otilibil@eurecom.fr>
Message-ID: <20240801093257.2700-3-otilibil@eurecom.fr>

Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
---
 src/set.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/set.c b/src/set.c
index 75560fd..b2fbd54 100644
--- a/src/set.c
+++ b/src/set.c
@@ -16,9 +16,19 @@ int set_main(int argc, const char *argv[])
 {
 	struct wgdevice *device = NULL;
 	int ret = 1;
+	const char *error_message = "Usage: %s %s <interface>"
+	  " [listen-port <port>]"
+	  " [fwmark <mark>]"
+	  " [private-key <file path>]"
+	  " [peer <base64 public key> [remove]"
+	  " [preshared-key <file path>]"
+	  " [endpoint <ip>:<port>]"
+	  " [persistent-keepalive <interval seconds>]"
+	  " [allowed-ips <ip1>/<cidr1>[,<ip2>/<cidr2>]...]"
+	  " ]...\n";
 
 	if (argc < 3) {
-		fprintf(stderr, "Usage: %s %s <interface> [listen-port <port>] [fwmark <mark>] [private-key <file path>] [peer <base64 public key> [remove] [preshared-key <file path>] [endpoint <ip>:<port>] [persistent-keepalive <interval seconds>] [allowed-ips <ip1>/<cidr1>[,<ip2>/<cidr2>]...] ]...\n", PROG_NAME, argv[0]);
+		fprintf(stderr, error_message, PROG_NAME, argv[0]);
 		return 1;
 	}
 
-- 
2.45.2


From otilibil at eurecom.fr  Thu Aug  1 09:43:58 2024
From: otilibil at eurecom.fr (Ariel Otilibili)
Date: Thu,  1 Aug 2024 11:43:58 +0200
Subject: [PATCH] wireguard-tools: Extracted error message for the sake of
 legibility
In-Reply-To: <20240801094932.4502-1-otilibil@eurecom.fr>
References: <20240725204917.192647-2-otilibil@eurecom.fr>
 <20240801094932.4502-1-otilibil@eurecom.fr>
Message-ID: <20240801094932.4502-2-otilibil@eurecom.fr>

Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
---
 src/set.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/set.c b/src/set.c
index 75560fd..b2fbd54 100644
--- a/src/set.c
+++ b/src/set.c
@@ -16,9 +16,19 @@ int set_main(int argc, const char *argv[])
 {
 	struct wgdevice *device = NULL;
 	int ret = 1;
+	const char *error_message = "Usage: %s %s <interface>"
+	  " [listen-port <port>]"
+	  " [fwmark <mark>]"
+	  " [private-key <file path>]"
+	  " [peer <base64 public key> [remove]"
+	  " [preshared-key <file path>]"
+	  " [endpoint <ip>:<port>]"
+	  " [persistent-keepalive <interval seconds>]"
+	  " [allowed-ips <ip1>/<cidr1>[,<ip2>/<cidr2>]...]"
+	  " ]...\n";
 
 	if (argc < 3) {
-		fprintf(stderr, "Usage: %s %s <interface> [listen-port <port>] [fwmark <mark>] [private-key <file path>] [peer <base64 public key> [remove] [preshared-key <file path>] [endpoint <ip>:<port>] [persistent-keepalive <interval seconds>] [allowed-ips <ip1>/<cidr1>[,<ip2>/<cidr2>]...] ]...\n", PROG_NAME, argv[0]);
+		fprintf(stderr, error_message, PROG_NAME, argv[0]);
 		return 1;
 	}
 
-- 
2.45.2


From syzbot+943d34fa3cf2191e3068 at syzkaller.appspotmail.com  Mon Aug 12 04:53:02 2024
From: syzbot+943d34fa3cf2191e3068 at syzkaller.appspotmail.com (syzbot)
Date: Sun, 11 Aug 2024 21:53:02 -0700
Subject: [syzbot] [wireguard?] WARNING in kthread_unpark (2)
In-Reply-To: <00000000000061c0a106183499ec@google.com>
Message-ID: <00000000000099eca4061f754420@google.com>

syzbot has bisected this issue to:

commit b3e40fc85735b787ce65909619fcd173107113c2
Author: Oliver Neukum <oneukum at suse.com>
Date:   Thu May 2 11:51:40 2024 +0000

    USB: usb_parse_endpoint: ignore reserved bits

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=11ca267d980000
start commit:   dc1c8034e31b minmax: simplify min()/max()/clamp() implemen..
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=13ca267d980000
console output: https://syzkaller.appspot.com/x/log.txt?x=15ca267d980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=2258b49cd9b339fa
dashboard link: https://syzkaller.appspot.com/bug?extid=943d34fa3cf2191e3068
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1022b573980000

Reported-by: syzbot+943d34fa3cf2191e3068 at syzkaller.appspotmail.com
Fixes: b3e40fc85735 ("USB: usb_parse_endpoint: ignore reserved bits")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

From seanjc at google.com  Fri Aug 16 18:24:35 2024
From: seanjc at google.com (Sean Christopherson)
Date: Fri, 16 Aug 2024 11:24:35 -0700
Subject: [syzbot] [kvm?] general protection fault in get_work_pool (2)
In-Reply-To: <0000000000006eb03a061b20c079@google.com>
References: <0000000000006eb03a061b20c079@google.com>
Message-ID: <Zr-ZY8HSGfVuoQpl@google.com>

On Mon, Jun 17, 2024, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    2ccbdf43d5e7 Merge tag 'for-linus' of git://git.kernel.org..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=16f23146980000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=81c0d76ceef02b39
> dashboard link: https://syzkaller.appspot.com/bug?extid=0dc211bc2adb944e1fd6
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
> userspace arch: i386
> 
> Unfortunately, I don't have any reproducer for this issue yet.
> 
> Downloadable assets:
> disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-2ccbdf43.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/13cdb5bfbafa/vmlinux-2ccbdf43.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/7a14f5d07f81/bzImage-2ccbdf43.xz
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+0dc211bc2adb944e1fd6 at syzkaller.appspotmail.com

See https://lore.kernel.org/all/Zr-Ydj8FBpiqmY_c at google.com for an explanation.

#syz invalid

From Jason at zx2c4.com  Fri Aug 16 22:16:03 2024
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Fri, 16 Aug 2024 22:16:03 +0000
Subject: [syzbot] [kvm?] general protection fault in get_work_pool (2)
In-Reply-To: <Zr-ZY8HSGfVuoQpl@google.com>
References: <0000000000006eb03a061b20c079@google.com>
 <Zr-ZY8HSGfVuoQpl@google.com>
Message-ID: <Zr_Po5Rj7wsDj_BX@zx2c4.com>

On Fri, Aug 16, 2024 at 11:24:35AM -0700, Sean Christopherson wrote:
> On Mon, Jun 17, 2024, syzbot wrote:
> > Hello,
> > 
> > syzbot found the following issue on:
> > 
> > HEAD commit:    2ccbdf43d5e7 Merge tag 'for-linus' of git://git.kernel.org..
> > git tree:       upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=16f23146980000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=81c0d76ceef02b39
> > dashboard link: https://syzkaller.appspot.com/bug?extid=0dc211bc2adb944e1fd6
> > compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
> > userspace arch: i386
> > 
> > Unfortunately, I don't have any reproducer for this issue yet.
> > 
> > Downloadable assets:
> > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-2ccbdf43.raw.xz
> > vmlinux: https://storage.googleapis.com/syzbot-assets/13cdb5bfbafa/vmlinux-2ccbdf43.xz
> > kernel image: https://storage.googleapis.com/syzbot-assets/7a14f5d07f81/bzImage-2ccbdf43.xz
> > 
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+0dc211bc2adb944e1fd6 at syzkaller.appspotmail.com
> 
> See https://lore.kernel.org/all/Zr-Ydj8FBpiqmY_c at google.com for an explanation.
> 
> #syz invalid

Oh. Thanks very much for following up on this. I spent some time puzzling
over it and didn't find a wireguard bug. Glad that turned out to be so.

Jason

From syzbot+9fd43bb1ae7b5d9240c3 at syzkaller.appspotmail.com  Sun Aug 18 06:06:23 2024
From: syzbot+9fd43bb1ae7b5d9240c3 at syzkaller.appspotmail.com (syzbot)
Date: Sat, 17 Aug 2024 23:06:23 -0700
Subject: [syzbot] [btrfs?] general protection fault in __alloc_workqueue
Message-ID: <000000000000f6f09e061feefd16@google.com>

Hello,

syzbot found the following issue on:

HEAD commit:    367b5c3d53e5 Add linux-next specific files for 20240816
git tree:       linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=12aa95f5980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=61ba6f3b22ee5467
dashboard link: https://syzkaller.appspot.com/bug?extid=9fd43bb1ae7b5d9240c3
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15b868dd980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/0b1b4e3cad3c/disk-367b5c3d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5bb090f7813c/vmlinux-367b5c3d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/6674cb0709b1/bzImage-367b5c3d.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9fd43bb1ae7b5d9240c3 at syzkaller.appspotmail.com

workqueue: Failed to create a rescuer kthread for wq "wg-crypt-": -EINTR
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 0 UID: 0 PID: 5585 Comm: syz-executor Not tainted 6.11.0-rc3-next-20240816-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
RIP: 0010:__lock_acquire+0x69/0x2040 kernel/locking/lockdep.c:5010
Code: b6 04 30 84 c0 0f 85 87 16 00 00 45 31 f6 83 3d b8 08 a9 0e 00 0f 84 ac 13 00 00 89 54 24 54 89 5c 24 68 4c 89 f8 48 c1 e8 03 <80> 3c 30 00 74 12 4c 89 ff e8 49 5c 8c 00 48 be 00 00 00 00 00 fc
RSP: 0018:ffffc9000306ec30 EFLAGS: 00010046
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: dffffc0000000000 R11: fffffbfff20318b6 R12: ffff88802c88bc00
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000
FS:  0000555563814500(0000) GS:ffff8880b9000000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f6ead045000 CR3: 0000000061be2000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5762
 touch_wq_lockdep_map kernel/workqueue.c:3876 [inline]
 __flush_workqueue+0x1e3/0x1770 kernel/workqueue.c:3918
 drain_workqueue+0xc9/0x3a0 kernel/workqueue.c:4082
 destroy_workqueue+0xba/0xc40 kernel/workqueue.c:5830
 __alloc_workqueue+0x1c30/0x1fb0 kernel/workqueue.c:5745
 alloc_workqueue+0xd6/0x210 kernel/workqueue.c:5758
 wg_newlink+0x260/0x640 drivers/net/wireguard/device.c:343
 rtnl_newlink_create net/core/rtnetlink.c:3510 [inline]
 __rtnl_newlink net/core/rtnetlink.c:3730 [inline]
 rtnl_newlink+0x1591/0x20a0 net/core/rtnetlink.c:3743
 rtnetlink_rcv_msg+0x73f/0xcf0 net/core/rtnetlink.c:6647
 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
 netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
 netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1357
 netlink_sendmsg+0x8e4/0xcb0 net/netlink/af_netlink.c:1901
 sock_sendmsg_nosec net/socket.c:730 [inline]
 __sock_sendmsg+0x221/0x270 net/socket.c:745
 __sys_sendto+0x3a8/0x500 net/socket.c:2204
 __do_sys_sendto net/socket.c:2216 [inline]
 __se_sys_sendto net/socket.c:2212 [inline]
 __x64_sys_sendto+0xde/0x100 net/socket.c:2212
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f943557bd0c
Code: 2a 5a 02 00 44 8b 4c 24 2c 4c 8b 44 24 20 89 c5 44 8b 54 24 28 48 8b 54 24 18 b8 2c 00 00 00 48 8b 74 24 10 8b 7c 24 08 0f 05 <48> 3d 00 f0 ff ff 77 34 89 ef 48 89 44 24 08 e8 70 5a 02 00 48 8b
RSP: 002b:00007ffd6d464f30 EFLAGS: 00000293 ORIG_RAX: 000000000000002c
RAX: ffffffffffffffda RBX: 00007f9436244620 RCX: 00007f943557bd0c
RDX: 000000000000003c RSI: 00007f9436244670 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007ffd6d464f84 R09: 000000000000000c
R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000003
R13: 0000000000000000 R14: 00007f9436244670 R15: 0000000000000000
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:__lock_acquire+0x69/0x2040 kernel/locking/lockdep.c:5010
Code: b6 04 30 84 c0 0f 85 87 16 00 00 45 31 f6 83 3d b8 08 a9 0e 00 0f 84 ac 13 00 00 89 54 24 54 89 5c 24 68 4c 89 f8 48 c1 e8 03 <80> 3c 30 00 74 12 4c 89 ff e8 49 5c 8c 00 48 be 00 00 00 00 00 fc
RSP: 0018:ffffc9000306ec30 EFLAGS: 00010046
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: dffffc0000000000 R11: fffffbfff20318b6 R12: ffff88802c88bc00
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000
FS:  0000555563814500(0000) GS:ffff8880b9000000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f6ead045000 CR3: 0000000061be2000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	b6 04                	mov    $0x4,%dh
   2:	30 84 c0 0f 85 87 16 	xor    %al,0x1687850f(%rax,%rax,8)
   9:	00 00                	add    %al,(%rax)
   b:	45 31 f6             	xor    %r14d,%r14d
   e:	83 3d b8 08 a9 0e 00 	cmpl   $0x0,0xea908b8(%rip)        # 0xea908cd
  15:	0f 84 ac 13 00 00    	je     0x13c7
  1b:	89 54 24 54          	mov    %edx,0x54(%rsp)
  1f:	89 5c 24 68          	mov    %ebx,0x68(%rsp)
  23:	4c 89 f8             	mov    %r15,%rax
  26:	48 c1 e8 03          	shr    $0x3,%rax
* 2a:	80 3c 30 00          	cmpb   $0x0,(%rax,%rsi,1) <-- trapping instruction
  2e:	74 12                	je     0x42
  30:	4c 89 ff             	mov    %r15,%rdi
  33:	e8 49 5c 8c 00       	call   0x8c5c81
  38:	48                   	rex.W
  39:	be 00 00 00 00       	mov    $0x0,%esi
  3e:	00 fc                	add    %bh,%ah


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller at googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

From syzbot+9fd43bb1ae7b5d9240c3 at syzkaller.appspotmail.com  Mon Aug 19 23:06:24 2024
From: syzbot+9fd43bb1ae7b5d9240c3 at syzkaller.appspotmail.com (syzbot)
Date: Mon, 19 Aug 2024 16:06:24 -0700
Subject: [syzbot] [btrfs?] general protection fault in __alloc_workqueue
In-Reply-To: <000000000000f6f09e061feefd16@google.com>
Message-ID: <000000000000adfbb70620115bdc@google.com>

syzbot has found a reproducer for the following issue on:

HEAD commit:    367b5c3d53e5 Add linux-next specific files for 20240816
git tree:       linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=16ef69f5980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=61ba6f3b22ee5467
dashboard link: https://syzkaller.appspot.com/bug?extid=9fd43bb1ae7b5d9240c3
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17582fbb980000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1060bfc5980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/0b1b4e3cad3c/disk-367b5c3d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5bb090f7813c/vmlinux-367b5c3d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/6674cb0709b1/bzImage-367b5c3d.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/af299b68d869/mount_2.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9fd43bb1ae7b5d9240c3 at syzkaller.appspotmail.com

workqueue: Failed to create a rescuer kthread for wq "btrfs-": -EINTR
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 0 UID: 0 PID: 8040 Comm: syz-executor149 Not tainted 6.11.0-rc3-next-20240816-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
RIP: 0010:__lock_acquire+0x69/0x2040 kernel/locking/lockdep.c:5010
Code: b6 04 30 84 c0 0f 85 87 16 00 00 45 31 f6 83 3d b8 08 a9 0e 00 0f 84 ac 13 00 00 89 54 24 54 89 5c 24 68 4c 89 f8 48 c1 e8 03 <80> 3c 30 00 74 12 4c 89 ff e8 49 5c 8c 00 48 be 00 00 00 00 00 fc
RSP: 0018:ffffc9000e68f030 EFLAGS: 00010046
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: dffffc0000000000 R11: fffffbfff20318b6 R12: ffff88802b298000
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000
FS:  00007fbb7be9e6c0(0000) GS:ffff8880b9000000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055df1c2ef668 CR3: 000000002e318000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5762
 touch_wq_lockdep_map kernel/workqueue.c:3876 [inline]
 __flush_workqueue+0x1e3/0x1770 kernel/workqueue.c:3918
 drain_workqueue+0xc9/0x3a0 kernel/workqueue.c:4082
 destroy_workqueue+0xba/0xc40 kernel/workqueue.c:5830
 __alloc_workqueue+0x1c30/0x1fb0 kernel/workqueue.c:5745
 alloc_workqueue+0xd6/0x210 kernel/workqueue.c:5758
 btrfs_alloc_workqueue+0x1c8/0x2a0 fs/btrfs/async-thread.c:112
 btrfs_init_workqueues+0x3af/0x740 fs/btrfs/disk-io.c:2004
 open_ctree+0x122c/0x2a10 fs/btrfs/disk-io.c:3364
 btrfs_fill_super fs/btrfs/super.c:965 [inline]
 btrfs_get_tree_super fs/btrfs/super.c:1888 [inline]
 btrfs_get_tree+0xe7a/0x1920 fs/btrfs/super.c:2114
 vfs_get_tree+0x90/0x2a0 fs/super.c:1800
 fc_mount+0x1b/0xb0 fs/namespace.c:1231
 btrfs_get_tree_subvol fs/btrfs/super.c:2077 [inline]
 btrfs_get_tree+0x652/0x1920 fs/btrfs/super.c:2115
 vfs_get_tree+0x90/0x2a0 fs/super.c:1800
 do_new_mount+0x2be/0xb40 fs/namespace.c:3507
 do_mount fs/namespace.c:3847 [inline]
 __do_sys_mount fs/namespace.c:4055 [inline]
 __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4032
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fbb7bf1346a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 1e 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbb7be9e088 EFLAGS: 00000282 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fbb7be9e0a0 RCX: 00007fbb7bf1346a
RDX: 0000000020005100 RSI: 0000000020005140 RDI: 00007fbb7be9e0a0
RBP: 0000000000000004 R08: 00007fbb7be9e0e0 R09: 0000000000005106
R10: 0000000000000012 R11: 0000000000000282 R12: 00007fbb7be9e0e0
R13: 0000000000000012 R14: 0000000000000003 R15: 0000000001000000
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:__lock_acquire+0x69/0x2040 kernel/locking/lockdep.c:5010
Code: b6 04 30 84 c0 0f 85 87 16 00 00 45 31 f6 83 3d b8 08 a9 0e 00 0f 84 ac 13 00 00 89 54 24 54 89 5c 24 68 4c 89 f8 48 c1 e8 03 <80> 3c 30 00 74 12 4c 89 ff e8 49 5c 8c 00 48 be 00 00 00 00 00 fc
RSP: 0018:ffffc9000e68f030 EFLAGS: 00010046
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: dffffc0000000000 R11: fffffbfff20318b6 R12: ffff88802b298000
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000000
FS:  00007fbb7be9e6c0(0000) GS:ffff8880b9000000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055df1c2ef668 CR3: 000000002e318000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	b6 04                	mov    $0x4,%dh
   2:	30 84 c0 0f 85 87 16 	xor    %al,0x1687850f(%rax,%rax,8)
   9:	00 00                	add    %al,(%rax)
   b:	45 31 f6             	xor    %r14d,%r14d
   e:	83 3d b8 08 a9 0e 00 	cmpl   $0x0,0xea908b8(%rip)        # 0xea908cd
  15:	0f 84 ac 13 00 00    	je     0x13c7
  1b:	89 54 24 54          	mov    %edx,0x54(%rsp)
  1f:	89 5c 24 68          	mov    %ebx,0x68(%rsp)
  23:	4c 89 f8             	mov    %r15,%rax
  26:	48 c1 e8 03          	shr    $0x3,%rax
* 2a:	80 3c 30 00          	cmpb   $0x0,(%rax,%rsi,1) <-- trapping instruction
  2e:	74 12                	je     0x42
  30:	4c 89 ff             	mov    %r15,%rdi
  33:	e8 49 5c 8c 00       	call   0x8c5c81
  38:	48                   	rex.W
  39:	be 00 00 00 00       	mov    $0x0,%esi
  3e:	00 fc                	add    %bh,%ah


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

From peter at korsgaard.com  Wed Aug 21 07:11:11 2024
From: peter at korsgaard.com (Peter Korsgaard)
Date: Wed, 21 Aug 2024 09:11:11 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
Message-ID: <87a5h6e4fk.fsf@dell.be.48ers.dk>

Hi Jason,

Did you recently upgrade xz on git.zx2c4.com? I see that the hash of
wireguard-tools-1.0.20210914.tar.xz changed:

http://autobuild.buildroot.org/results/d63b8f5b14487f6d79c9779bb7fe4829fae0653b/build-end.log

We have a backup of the original file on sources.buildroot.net:

mkdir a b
wget -q -P a https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20210914.tar.xz
wget -q -P b https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20210914.tar.xz

sha256sum */*
942ed32d1d6631932c82ff86c91ae8428d4c90bfec231a14ebdf6c29f068e60b  a/wireguard-tools-1.0.20210914.tar.xz
97ff31489217bb265b7ae850d3d0f335ab07d2652ba1feec88b734bc96bd05ac  b/wireguard-tools-1.0.20210914.tar.xz

The uncompressed tarball is identical:

unxz */*xz
sha256sum */*tar
22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d  a/wireguard-tools-1.0.20210914.tar
22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d  b/wireguard-tools-1.0.20210914.tar

It would be great if we could have a bit-identical .tar.xz.

-- 
Bye, Peter Korsgaard

From ml+wireguard at 03s.net  Sun Aug 25 16:50:14 2024
From: ml+wireguard at 03s.net (Adrian Ho)
Date: Mon, 26 Aug 2024 00:50:14 +0800
Subject: Changed SHA256 of wireguard-go 0.0.20230223 source tarball
Message-ID: <610ED0E6-95D0-4D54-AD9A-8BF0AD8D25E9@03s.net>

[Originally posted in IRC, but my Libera Web client seems to have logged me out, so apologies if it was already answered there, as I don?t see any history.]

Hi! I help out with the Homebrew project, and one of our users just alerted us to a SHA256 checksum failure on the above tarball (https://git.zx2c4.com/wireguard-go/snapshot/wireguard-go-0.0.20230223.tar.xz). The checksum at the time our formula was updated with this release was ed3694e808d96720e79e17ae396f89f7c2024da07f3449ff0af8fbc6dbfa7f6a, recorded on Thu Feb 23 12:49:17 2023 -0800. The current checksum is 50029ca43196cc3d925c0f0b98a9fcfd7f6c28465122da90ebe5262398f3b31c, so was the tarball regenerated since that time?

Thanks much!

Best Regards,
Adrian


From peter at korsgaard.com  Mon Aug 26 07:36:57 2024
From: peter at korsgaard.com (Peter Korsgaard)
Date: Mon, 26 Aug 2024 09:36:57 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <87a5h6e4fk.fsf@dell.be.48ers.dk> (Peter Korsgaard's message of
 "Wed, 21 Aug 2024 09:11:11 +0200")
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
Message-ID: <87y14jbuqu.fsf@dell.be.48ers.dk>

>>>>> "Peter" == Peter Korsgaard <peter at korsgaard.com> writes:

Hello Jason,

Was this change done on purpose?

 > Hi Jason,
 > Did you recently upgrade xz on git.zx2c4.com? I see that the hash of
 > wireguard-tools-1.0.20210914.tar.xz changed:

 > http://autobuild.buildroot.org/results/d63b8f5b14487f6d79c9779bb7fe4829fae0653b/build-end.log

 > We have a backup of the original file on sources.buildroot.net:

 > mkdir a b
 > wget -q -P a
 > https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20210914.tar.xz
 > wget -q -P b https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20210914.tar.xz

 > sha256sum */*
 > 942ed32d1d6631932c82ff86c91ae8428d4c90bfec231a14ebdf6c29f068e60b
 > a/wireguard-tools-1.0.20210914.tar.xz
 > 97ff31489217bb265b7ae850d3d0f335ab07d2652ba1feec88b734bc96bd05ac
 > b/wireguard-tools-1.0.20210914.tar.xz

 > The uncompressed tarball is identical:

 > unxz */*xz
 > sha256sum */*tar
 > 22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d
 > a/wireguard-tools-1.0.20210914.tar
 > 22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d
 > b/wireguard-tools-1.0.20210914.tar

 > It would be great if we could have a bit-identical .tar.xz.

 > -- 
 > Bye, Peter Korsgaard

-- 
Bye, Peter Korsgaard

From Jason at zx2c4.com  Mon Aug 26 08:35:12 2024
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Mon, 26 Aug 2024 10:35:12 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <87a5h6e4fk.fsf@dell.be.48ers.dk>
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
Message-ID: <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>

On Wed, Aug 21, 2024 at 9:11?AM Peter Korsgaard <peter at korsgaard.com> wrote:
>
> Hi Jason,
>
> Did you recently upgrade xz on git.zx2c4.com? I see that the hash of
> wireguard-tools-1.0.20210914.tar.xz changed:
>
> http://autobuild.buildroot.org/results/d63b8f5b14487f6d79c9779bb7fe4829fae0653b/build-end.log
>
> We have a backup of the original file on sources.buildroot.net:
>
> mkdir a b
> wget -q -P a https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20210914.tar.xz
> wget -q -P b https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20210914.tar.xz
>
> sha256sum */*
> 942ed32d1d6631932c82ff86c91ae8428d4c90bfec231a14ebdf6c29f068e60b  a/wireguard-tools-1.0.20210914.tar.xz
> 97ff31489217bb265b7ae850d3d0f335ab07d2652ba1feec88b734bc96bd05ac  b/wireguard-tools-1.0.20210914.tar.xz
>
> The uncompressed tarball is identical:
>
> unxz */*xz
> sha256sum */*tar
> 22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d  a/wireguard-tools-1.0.20210914.tar
> 22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d  b/wireguard-tools-1.0.20210914.tar
>
> It would be great if we could have a bit-identical .tar.xz.

I updated xz on the system. Bah, that's annoying.

I've downgraded it now and the hash should check out. But this issue
is sure to come up again in the future....

Jason

From Jason at zx2c4.com  Mon Aug 26 08:35:12 2024
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Mon, 26 Aug 2024 10:35:12 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <87a5h6e4fk.fsf@dell.be.48ers.dk>
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
Message-ID: <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>

On Wed, Aug 21, 2024 at 9:11?AM Peter Korsgaard <peter at korsgaard.com> wrote:
>
> Hi Jason,
>
> Did you recently upgrade xz on git.zx2c4.com? I see that the hash of
> wireguard-tools-1.0.20210914.tar.xz changed:
>
> http://autobuild.buildroot.org/results/d63b8f5b14487f6d79c9779bb7fe4829fae0653b/build-end.log
>
> We have a backup of the original file on sources.buildroot.net:
>
> mkdir a b
> wget -q -P a https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20210914.tar.xz
> wget -q -P b https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20210914.tar.xz
>
> sha256sum */*
> 942ed32d1d6631932c82ff86c91ae8428d4c90bfec231a14ebdf6c29f068e60b  a/wireguard-tools-1.0.20210914.tar.xz
> 97ff31489217bb265b7ae850d3d0f335ab07d2652ba1feec88b734bc96bd05ac  b/wireguard-tools-1.0.20210914.tar.xz
>
> The uncompressed tarball is identical:
>
> unxz */*xz
> sha256sum */*tar
> 22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d  a/wireguard-tools-1.0.20210914.tar
> 22d6d0b12ec69be002313a89dbe2c08c07d48c5b93af528189ceab351b3b718d  b/wireguard-tools-1.0.20210914.tar
>
> It would be great if we could have a bit-identical .tar.xz.

I updated xz on the system. Bah, that's annoying.

I've downgraded it now and the hash should check out. But this issue
is sure to come up again in the future....

Jason

From Jason at zx2c4.com  Mon Aug 26 08:52:55 2024
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Mon, 26 Aug 2024 10:52:55 +0200
Subject: Changed SHA256 of wireguard-go 0.0.20230223 source tarball
In-Reply-To: <610ED0E6-95D0-4D54-AD9A-8BF0AD8D25E9@03s.net>
References: <610ED0E6-95D0-4D54-AD9A-8BF0AD8D25E9@03s.net>
Message-ID: <CAHmME9rikm_nXSP85R3hQix++NrrS_TGMBkX50fYjUyqnTRQSA@mail.gmail.com>

https://lists.zx2c4.com/pipermail/wireguard/2024-August/008466.html

From peter at korsgaard.com  Mon Aug 26 09:02:51 2024
From: peter at korsgaard.com (Peter Korsgaard)
Date: Mon, 26 Aug 2024 11:02:51 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>
 (Jason A. Donenfeld's message of "Mon, 26 Aug 2024 10:35:12 +0200")
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
 <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>
Message-ID: <87bk1fbqro.fsf@dell.be.48ers.dk>

>>>>> "Jason" == Jason A Donenfeld <Jason at zx2c4.com> writes:

Hi Jason,

 >> It would be great if we could have a bit-identical .tar.xz.

 > I updated xz on the system. Bah, that's annoying.

 > I've downgraded it now and the hash should check out. But this issue
 > is sure to come up again in the future....

Thanks! I've verified that it is indeed correct again. Out of interest,
what xz versions were this about exactly?

For Buildroot I will have a look at moving these autogenerated /
snapshot downloads to the .tar.gz variant that is probably more stable
over versions.

-- 
Bye, Peter Korsgaard

From Jason at zx2c4.com  Mon Aug 26 09:04:41 2024
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Mon, 26 Aug 2024 11:04:41 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <87bk1fbqro.fsf@dell.be.48ers.dk>
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
 <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>
 <87bk1fbqro.fsf@dell.be.48ers.dk>
Message-ID: <CAHmME9qot4_njP1DnBTRYhkRC93cetwi-ttwM_77ibm2X90Cng@mail.gmail.com>

On Mon, Aug 26, 2024 at 11:02?AM Peter Korsgaard <peter at korsgaard.com> wrote:
>
> >>>>> "Jason" == Jason A Donenfeld <Jason at zx2c4.com> writes:
>
> Hi Jason,
>
>  >> It would be great if we could have a bit-identical .tar.xz.
>
>  > I updated xz on the system. Bah, that's annoying.
>
>  > I've downgraded it now and the hash should check out. But this issue
>  > is sure to come up again in the future....
>
> Thanks! I've verified that it is indeed correct again. Out of interest,
> what xz versions were this about exactly?

I downgraded from the latest one to the one that existed before Jia
Tan appeared.

> For Buildroot I will have a look at moving these autogenerated /
> snapshot downloads to the .tar.gz variant that is probably more stable
> over versions.

Long term I intend to move everything over to .zst, I think.

From peter at korsgaard.com  Mon Aug 26 09:14:27 2024
From: peter at korsgaard.com (Peter Korsgaard)
Date: Mon, 26 Aug 2024 11:14:27 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <CAHmME9qot4_njP1DnBTRYhkRC93cetwi-ttwM_77ibm2X90Cng@mail.gmail.com>
 (Jason A. Donenfeld's message of "Mon, 26 Aug 2024 11:04:41 +0200")
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
 <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>
 <87bk1fbqro.fsf@dell.be.48ers.dk>
 <CAHmME9qot4_njP1DnBTRYhkRC93cetwi-ttwM_77ibm2X90Cng@mail.gmail.com>
Message-ID: <877cc3bq8c.fsf@dell.be.48ers.dk>

>>>>> "Jason" == Jason A Donenfeld <Jason at zx2c4.com> writes:

Hi,

 >> For Buildroot I will have a look at moving these autogenerated /
 >> snapshot downloads to the .tar.gz variant that is probably more stable
 >> over versions.

 > Long term I intend to move everything over to .zst, I think.

OK. Do you have reasons to expect .zst output to be bit identical
between versions? It presumably means that the compression ratio can not
improve over time, hence my suggestion for a legacy format like .gz.

The trigger for all of this is the on the fly snapshot generation from
cgit. How about archiving the snapshot tarballs somewhere permanent
instead?

-- 
Bye, Peter Korsgaard

From kim at wayoftao.net  Mon Aug 26 09:19:19 2024
From: kim at wayoftao.net (Kim Nilsson)
Date: Mon, 26 Aug 2024 11:19:19 +0200
Subject: wireguard-tools-1.0.20210914.tar.xz hash changed
In-Reply-To: <CAHmME9qot4_njP1DnBTRYhkRC93cetwi-ttwM_77ibm2X90Cng@mail.gmail.com>
References: <87a5h6e4fk.fsf@dell.be.48ers.dk>
 <CAHmME9qXiEmKTZ56+bz3-ZP3udQsgZHcKtV3RU_WK1as9c=e4Q@mail.gmail.com>
 <87bk1fbqro.fsf@dell.be.48ers.dk>
 <CAHmME9qot4_njP1DnBTRYhkRC93cetwi-ttwM_77ibm2X90Cng@mail.gmail.com>
Message-ID: <ac8a1d42-b43a-439b-b4f3-691c2673bbf6@wayoftao.net>

Hi,


FWIW I did a manual byte-for-byte comparison between the two files last 
week and the change is that the newer version adds two more headers; one 
for compressed file size, and one for uncompressed file size. The values 
encoded therein are correct as well. As per the xz specification they 
are included to aid decompression software.


Regards,

Kim Nilsson

On 8/26/24 11:04 AM, Jason A. Donenfeld wrote:
> On Mon, Aug 26, 2024 at 11:02?AM Peter Korsgaard <peter at korsgaard.com> wrote:
>>>>>>> "Jason" == Jason A Donenfeld <Jason at zx2c4.com> writes:
>> Hi Jason,
>>
>>   >> It would be great if we could have a bit-identical .tar.xz.
>>
>>   > I updated xz on the system. Bah, that's annoying.
>>
>>   > I've downgraded it now and the hash should check out. But this issue
>>   > is sure to come up again in the future....
>>
>> Thanks! I've verified that it is indeed correct again. Out of interest,
>> what xz versions were this about exactly?
> I downgraded from the latest one to the one that existed before Jia
> Tan appeared.
>
>> For Buildroot I will have a look at moving these autogenerated /
>> snapshot downloads to the .tar.gz variant that is probably more stable
>> over versions.
> Long term I intend to move everything over to .zst, I think.