[PATCH net-next v2 01/14] net: ipv4: Add a flags argument to iptunnel_xmit(), udp_tunnel_xmit_skb()

[Petr Machata]

Jakub Kicinski <kuba at kernel.org> writes:

> On Thu, 12 Jun 2025 22:10:35 +0200 Petr Machata wrote:
>>  void udp_tunnel_xmit_skb(struct rtable *rt, struct sock *sk, struct sk_buff *skb,
>>  			 __be32 src, __be32 dst, __u8 tos, __u8 ttl,
>>  			 __be16 df, __be16 src_port, __be16 dst_port,
>> -			 bool xnet, bool nocheck)
>> +			 bool xnet, bool nocheck, u16 ipcb_flags)
>
> This is a lot of arguments for a function.
> I don't have a great suggestion off the top of my head, but maybe
> think more about it?

It wraps functions that take many arguments ^o^

We could exchange src_port, dst_port by passing in the UDP header
directly, but I don't think that's a good idea.

I guess I don't have great ideas either.