Syntax highlighting broken.

Ferry Huberts mailings at hupie.com
Mon Aug 12 21:57:11 CEST 2013



On 12/08/13 21:29, Jason A. Smith wrote:
> I understand the desire to move to a newer and possibly better syntax
> highlighting tool like that python script, but since that requires
> python version 3, it is not possible to use on a RHEL5/6 server, which
> is a show-stopper for us. RHEL7 will probably have it, but we need to
> use the current Enterprise OSes here and RHEL7 probably won't be out for
> close to another year.

I fully agree.

Although RHEL7 will probably be out a bit sooner than that ;-)


> 
> ~Jason
> 
> 
> On 08/12/2013 03:23 PM, Ferry Huberts wrote:
>> We include scripting to use the highlight tool.
>> IMHO we therefore should also ship the corresponding css.
>> Removal is very unfortunate and makes the lives of users and packagers
>> hard without a good reason. I frowned when I saw the patch but didn't
>> want to comment until now.
>>
>> Either do none of it, or do all of it. I vote for all of it.
>>
>> Please resurrect the css
>>
>> On 12/08/13 21:07, Jason A. Donenfeld wrote:
>>> This CSS was removed so that cgit could support multiple highlighting
>>> engines without preferring one over another. Either include this CSS
>>> along with the highlighted output in <style> tags (as in the case of
>>> [1]) or add it back to the global CSS yourself.
>>>
>>> [1] http://git.zx2c4.com/cgit/tree/filters/syntax-highlighting.py
>>> _______________________________________________
>>> CGit mailing list
>>> CGit at lists.zx2c4.com
>>> http://lists.zx2c4.com/mailman/listinfo/cgit
>>>
>>
> 

-- 
Ferry Huberts


More information about the CGit mailing list