[PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes
john at keeping.me.uk
Thu Mar 7 10:07:11 CET 2013
On Thu, Mar 07, 2013 at 09:16:50AM +0100, Lukas Fleischer wrote:
> On Thu, Mar 07, 2013 at 09:03:11AM +0100, René Neumann wrote:
> > > +# Only cgit.c reference CGIT_VERSION so we only rebuild its objects when the
> > > +# version changes.
> > > +CGIT_VERSION_OBJS := $(addprefix $(CGIT_PREFIX),cgit.o)
> > > +$(CGIT_VERSION_OBJS): $(CGIT_PREFIX)VERSION
> > > +$(CGIT_VERSION_OBJS): EXTRA_CPPFLAGS = \
> > > + -DCGIT_VERSION='"$(CGIT_VERSION)"'
> > Is the small gain (not rebuilding a couple of small C-files) worth this
> > hassle? Because it sounds a bit like a maintenance nightmare: One more
> > place to remember to put a file.
It's not a couple of C files, it's *all* of the CGit C files.
> > If cgit were some template-C++-monster, this might be useful, but cgit
> > is not...
> I don't think any other file should reference CGIT_VERSION in the
> future, see patch 2/4 in this patch set.
Exactly. We shouldn't ever need to use the #define'd CGIT_VERSION in
more than one place.
More information about the CGit