[PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes
lists at necoro.eu
Thu Mar 7 10:49:53 CET 2013
Am 07.03.2013 10:07, schrieb John Keeping:
> On Thu, Mar 07, 2013 at 09:16:50AM +0100, Lukas Fleischer wrote:
>> On Thu, Mar 07, 2013 at 09:03:11AM +0100, René Neumann wrote:
>>>> +# Only cgit.c reference CGIT_VERSION so we only rebuild its objects when the
>>>> +# version changes.
>>>> +CGIT_VERSION_OBJS := $(addprefix $(CGIT_PREFIX),cgit.o)
>>>> +$(CGIT_VERSION_OBJS): $(CGIT_PREFIX)VERSION
>>>> +$(CGIT_VERSION_OBJS): EXTRA_CPPFLAGS = \
>>>> + -DCGIT_VERSION='"$(CGIT_VERSION)"'
>>> Is the small gain (not rebuilding a couple of small C-files) worth this
>>> hassle? Because it sounds a bit like a maintenance nightmare: One more
>>> place to remember to put a file.
> It's not a couple of C files, it's *all* of the CGit C files.
Well, in my perspective, *all* of CGit C files _is_ 'a couple'.
> Exactly. We shouldn't ever need to use the #define'd CGIT_VERSION in
> more than one place.
That's a fair point.
More information about the CGit