[PATCH v2 00/22] HTTP status code improvements

John Keeping john at keeping.me.uk
Fri Aug 14 16:20:23 CEST 2015

On Fri, Aug 14, 2015 at 03:56:43PM +0200, Jason A. Donenfeld wrote:
> Thanks for this series. The approach to caching seems like a decent
> tradeoff. I'd be interested in hearing dissenting opinions on this
> though. It's not to late to come up with something better before
> release time.
> The set looks good, and I've gone ahead and merged it to master. This
> also allowed me to add another patch ontop of it getting rid of the
> cmd pre() function, which was nice.

Nice, but it looks like you missed a bit...

-- >8 --
Subject: [PATCH] cmd: fix command definition

The previous commit removed the "pre" field from "struct cgit_cmd" but
forgot to update this macro.

Signed-off-by: John Keeping <john at keeping.me.uk>
 cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd.c b/cmd.c
index 20c80b0..c991092 100644
--- a/cmd.c
+++ b/cmd.c
@@ -142,7 +142,7 @@ static void tree_fn(void)
 #define def_cmd(name, want_repo, want_vpath, is_clone) \
-	{#name, name##_fn, NULL, want_repo, want_vpath, is_clone}
+	{#name, name##_fn, want_repo, want_vpath, is_clone}
 struct cgit_cmd *cgit_get_cmd(void)

More information about the CGit mailing list