[PATCH v2 00/22] HTTP status code improvements

[Christian Hesse]

John Keeping <john at keeping.me.uk> on Fri, 2015/08/14 15:20:
> On Fri, Aug 14, 2015 at 03:56:43PM +0200, Jason A. Donenfeld wrote:
> > Thanks for this series. The approach to caching seems like a decent
> > tradeoff. I'd be interested in hearing dissenting opinions on this
> > though. It's not to late to come up with something better before
> > release time.
> > 
> > The set looks good, and I've gone ahead and merged it to master. This
> > also allowed me to add another patch ontop of it getting rid of the
> > cmd pre() function, which was nice.
> 
> Nice, but it looks like you missed a bit...

Ah, John was three minutes faster, so...

Reviewed-by: Christian Hesse <mail at eworm.de>

> -- >8 --
> Subject: [PATCH] cmd: fix command definition
> 
> The previous commit removed the "pre" field from "struct cgit_cmd" but
> forgot to update this macro.
> 
> Signed-off-by: John Keeping <john at keeping.me.uk>
> ---
>  cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd.c b/cmd.c
> index 20c80b0..c991092 100644
> --- a/cmd.c
> +++ b/cmd.c
> @@ -142,7 +142,7 @@ static void tree_fn(void)
>  }
>  
>  #define def_cmd(name, want_repo, want_vpath, is_clone) \
> -	{#name, name##_fn, NULL, want_repo, want_vpath, is_clone}
> +	{#name, name##_fn, want_repo, want_vpath, is_clone}
>  
>  struct cgit_cmd *cgit_get_cmd(void)
>  {



-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20150814/36c02f2b/attachment.asc>