[PATCH 02/13] Avoid non-ANSI function declarations
John Keeping
john at keeping.me.uk
Sun Mar 8 17:32:16 CET 2015
Sparse says things like:
warning: non-ANSI function declaration of function 'calc_ttl'
Signed-off-by: John Keeping <john at keeping.me.uk>
---
cgit.c | 2 +-
filter.c | 2 +-
ui-diff.c | 2 +-
ui-refs.c | 4 ++--
ui-repolist.c | 6 +++---
ui-shared.c | 12 ++++++------
ui-ssdiff.c | 16 ++++++++--------
ui-summary.c | 2 +-
ui-tree.c | 4 ++--
9 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/cgit.c b/cgit.c
index 0ad8171..c16ed8c 100644
--- a/cgit.c
+++ b/cgit.c
@@ -1013,7 +1013,7 @@ static void cgit_parse_args(int argc, const char **argv)
}
}
-static int calc_ttl()
+static int calc_ttl(void)
{
if (!ctx.repo)
return ctx.cfg.cache_root_ttl;
diff --git a/filter.c b/filter.c
index 9f433db..ebf4937 100644
--- a/filter.c
+++ b/filter.c
@@ -72,7 +72,7 @@ static inline void hook_write(struct cgit_filter *filter, ssize_t (*new_write)(s
filter_write = new_write;
}
-static inline void unhook_write()
+static inline void unhook_write(void)
{
assert(filter_write != NULL);
assert(current_write_filter != NULL);
diff --git a/ui-diff.c b/ui-diff.c
index 5b6df1f..8eff178 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -311,7 +311,7 @@ static void filepair_cb(struct diff_filepair *pair)
cgit_ssdiff_footer();
}
-void cgit_print_diff_ctrls()
+void cgit_print_diff_ctrls(void)
{
int i, curr;
diff --git a/ui-refs.c b/ui-refs.c
index ac8a6d4..d3d71dd 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -82,7 +82,7 @@ static int print_branch(struct refinfo *ref)
return 0;
}
-static void print_tag_header()
+static void print_tag_header(void)
{
html("<tr class='nohover'><th class='left'>Tag</th>"
"<th class='left'>Download</th>"
@@ -234,7 +234,7 @@ void cgit_print_tags(int maxcount)
cgit_free_reflist_inner(&list);
}
-void cgit_print_refs()
+void cgit_print_refs(void)
{
html("<table class='list nowrap'>");
diff --git a/ui-repolist.c b/ui-repolist.c
index e945f67..a6d0321 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -117,7 +117,7 @@ static void print_sort_header(const char *title, const char *sort)
htmlf("'>%s</a></th>", title);
}
-static void print_header()
+static void print_header(void)
{
html("<tr class='nohover'>");
print_sort_header("Name", "name");
@@ -247,7 +247,7 @@ static int sort_repolist(char *field)
}
-void cgit_print_repolist()
+void cgit_print_repolist(void)
{
int i, columns = 3, hits = 0, header = 0;
char *last_section = NULL;
@@ -344,7 +344,7 @@ void cgit_print_repolist()
cgit_print_docend();
}
-void cgit_print_site_readme()
+void cgit_print_site_readme(void)
{
if (!ctx.cfg.root_readme)
return;
diff --git a/ui-shared.c b/ui-shared.c
index ff03cb2..6d3cfa9 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -46,7 +46,7 @@ void cgit_vprint_error(const char *fmt, va_list ap)
html("</div>\n");
}
-const char *cgit_httpscheme()
+const char *cgit_httpscheme(void)
{
if (ctx.env.https && !strcmp(ctx.env.https, "on"))
return "https://";
@@ -54,7 +54,7 @@ const char *cgit_httpscheme()
return "http://";
}
-const char *cgit_hosturl()
+const char *cgit_hosturl(void)
{
if (ctx.env.http_host)
return ctx.env.http_host;
@@ -65,14 +65,14 @@ const char *cgit_hosturl()
return fmtalloc("%s:%s", ctx.env.server_name, ctx.env.server_port);
}
-const char *cgit_currenturl()
+const char *cgit_currenturl(void)
{
if (!ctx.qry.url)
return cgit_rooturl();
return ctx.qry.url;
}
-const char *cgit_rooturl()
+const char *cgit_rooturl(void)
{
if (ctx.cfg.virtual_root)
return ctx.cfg.virtual_root;
@@ -80,7 +80,7 @@ const char *cgit_rooturl()
return ctx.cfg.script_name;
}
-const char *cgit_loginurl()
+const char *cgit_loginurl(void)
{
static const char *login_url = 0;
if (!login_url)
@@ -735,7 +735,7 @@ void cgit_print_docstart(void)
html_include(ctx.cfg.header);
}
-void cgit_print_docend()
+void cgit_print_docend(void)
{
html("</div> <!-- class=content -->\n");
if (ctx.cfg.embedded) {
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 08cf513..2146c71 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -18,7 +18,7 @@ struct deferred_lines {
static struct deferred_lines *deferred_old, *deferred_old_last;
static struct deferred_lines *deferred_new, *deferred_new_last;
-static void create_or_reset_lcs_table()
+static void create_or_reset_lcs_table(void)
{
int i;
@@ -276,7 +276,7 @@ static void print_ssdiff_line(char *class,
free(old_line);
}
-static void print_deferred_old_lines()
+static void print_deferred_old_lines(void)
{
struct deferred_lines *iter_old, *tmp;
iter_old = deferred_old;
@@ -289,7 +289,7 @@ static void print_deferred_old_lines()
}
}
-static void print_deferred_new_lines()
+static void print_deferred_new_lines(void)
{
struct deferred_lines *iter_new, *tmp;
iter_new = deferred_new;
@@ -302,7 +302,7 @@ static void print_deferred_new_lines()
}
}
-static void print_deferred_changed_lines()
+static void print_deferred_changed_lines(void)
{
struct deferred_lines *iter_old, *iter_new, *tmp;
int n_old_lines = calc_deferred_lines(deferred_old);
@@ -337,7 +337,7 @@ static void print_deferred_changed_lines()
}
}
-void cgit_ssdiff_print_deferred_lines()
+void cgit_ssdiff_print_deferred_lines(void)
{
if (!deferred_old && !deferred_new)
return;
@@ -388,7 +388,7 @@ void cgit_ssdiff_line_cb(char *line, int len)
line[len - 1] = c;
}
-void cgit_ssdiff_header_begin()
+void cgit_ssdiff_header_begin(void)
{
current_old_line = -1;
current_new_line = -1;
@@ -396,12 +396,12 @@ void cgit_ssdiff_header_begin()
html("<tr><td class='head' colspan='4'>");
}
-void cgit_ssdiff_header_end()
+void cgit_ssdiff_header_end(void)
{
html("</td><tr>");
}
-void cgit_ssdiff_footer()
+void cgit_ssdiff_footer(void)
{
if (deferred_old || deferred_new)
cgit_ssdiff_print_deferred_lines();
diff --git a/ui-summary.c b/ui-summary.c
index fa5ba04..b0af073 100644
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -40,7 +40,7 @@ static void print_url(const char *url)
html("</a></td></tr>\n");
}
-void cgit_print_summary()
+void cgit_print_summary(void)
{
int columns = 3;
diff --git a/ui-tree.c b/ui-tree.c
index 4ab0137..bbc468e 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -180,7 +180,7 @@ static int ls_item(const unsigned char *sha1, struct strbuf *base,
return 0;
}
-static void ls_head()
+static void ls_head(void)
{
html("<table summary='tree listing' class='list'>\n");
html("<tr class='nohover'>");
@@ -191,7 +191,7 @@ static void ls_head()
html("</tr>\n");
}
-static void ls_tail()
+static void ls_tail(void)
{
html("</table>\n");
}
--
2.3.1.308.g754cd77
More information about the CGit
mailing list