Small patch makes cgit crash
Sylvain Rabot
sylvain at abstraction.fr
Fri Oct 7 11:27:13 CEST 2016
Hi,
I've made a small patch to make cgit's summary layout look more like
gitweb's. It works but in some cases which I wasn't able to determine
the particulars it seems to crash and the clone url and the footer are
not displayed, e.g. :
- not displayed: http://cgit.abstraction.fr/cgit.cgi/meld.git/
- displayed: http://cgit.abstraction.fr/cgit.cgi/postgresql.git/
Here's the patch :
diff --git a/ui-summary.c b/ui-summary.c
index 8e81ac4..d84faad 100644
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -51,14 +51,14 @@ void cgit_print_summary(void)
cgit_print_layout_start();
html("<table summary='repository info' class='list nowrap'>");
- cgit_print_branches(ctx.cfg.summary_branches);
- htmlf("<tr class='nohover'><td colspan='%d'> </td></tr>", columns);
- cgit_print_tags(ctx.cfg.summary_tags);
if (ctx.cfg.summary_log > 0) {
- htmlf("<tr class='nohover'><td
colspan='%d'> </td></tr>", columns);
cgit_print_log(ctx.qry.head, 0, ctx.cfg.summary_log, NULL,
NULL, NULL, 0, 0, 0);
+ htmlf("<tr class='nohover'><td
colspan='%d'> </td></tr>", columns);
}
+ cgit_print_tags(ctx.cfg.summary_tags);
+ htmlf("<tr class='nohover'><td colspan='%d'> </td></tr>", columns);
+ cgit_print_branches(ctx.cfg.summary_branches);
urls = 0;
cgit_add_clone_urls(print_url);
html("</table>");
I would appreciate any help.
Best regards.
--
Sylvain Rabot <sylvain at abstraction.fr>
More information about the CGit
mailing list