Rendering of inline with inner tree view dirs

Andy Green andy at
Tue Jun 12 11:27:09 CEST 2018

On June 12, 2018 5:24:37 PM GMT+08:00, John Keeping <john at> wrote:
>On Tue, Jun 12, 2018 at 10:35:25AM +0200, Christian Hesse wrote:
>> Andy Green <andy at> on Tue, 2018/06/12 13:53:
>> > 5) I get some gcc 8.1 warnings, I made a couple of patches to get
>> > them.  In a couple of places, the code seemed legit really.
>> I do see these on Arch as well. :)
>> Did not find the time to address them.
>> > [inline patches]
>> > 
>> > I should include these or the slightly dubious warnings are just 
>> > regarded as an annoyance?
>> Definitely to be addressed. I pushed your changes here:
>> Builds without warnings and tests are happy, but I did not yet take a
>> detailed look.
>We'll need those posted as proper patches with a sign-off though.  It
>will also be easier to review them that way.

No worries I'll send a series with everything including your rebased patches when the remaining things are sorted.  I was checking if anyone cared about the warnings.



More information about the CGit mailing list