Rendering of README.md inline with inner tree view dirs
john at keeping.me.uk
Tue Jun 12 14:07:07 CEST 2018
On Tue, Jun 12, 2018 at 05:27:09PM +0800, Andy Green wrote:
> On June 12, 2018 5:24:37 PM GMT+08:00, John Keeping <john at keeping.me.uk> wrote:
> >On Tue, Jun 12, 2018 at 10:35:25AM +0200, Christian Hesse wrote:
> >> Andy Green <andy at warmcat.com> on Tue, 2018/06/12 13:53:
> >> > 5) I get some gcc 8.1 warnings, I made a couple of patches to get
> >> > them. In a couple of places, the code seemed legit really.
> >> I do see these on Arch as well. :)
> >> Did not find the time to address them.
> >> > [inline patches]
> >> >
> >> > I should include these or the slightly dubious warnings are just
> >> > regarded as an annoyance?
> >> Definitely to be addressed. I pushed your changes here:
> >> https://git.zx2c4.com/cgit/commit/?h=ch/gcc-8&id=e7ac824f
> >> Builds without warnings and tests are happy, but I did not yet take a
> >> detailed look.
> >We'll need those posted as proper patches with a sign-off though. It
> >will also be easier to review them that way.
> No worries I'll send a series with everything including your rebased
> patches when the remaining things are sorted. I was checking if
> anyone cared about the warnings.
If the GCC-8 fixes are independent of the other changes (from a quick
skim I think they are), then please send them as a separate series so
that we can get the warnings fixes in without waiting for other changes.
More information about the CGit