[PATCH v2 1/1] ui-ssdiff: ban strncat()

Eric Wong e at 80x24.org
Wed Feb 13 09:29:02 CET 2019

Christian Hesse <list at eworm.de> wrote:
> From: Christian Hesse <mail at eworm.de>
> Git version v2.21.0 marks strncat() as banned (commit
> ace5707a803eda0f1dde3d776dc3729d3bc7759a), so replace it.

Btw, I posted a similar-in-spirit patch to replace strncat
in ui-ssdiff.c back in January: <20190102073710.580-1-e at 80x24.org>

It uses strbuf and is close to code which already exists in
git.git, so it doesn't make calls to strlen() repeatedly.

(I'm also responsible for strncat banning in git.git :)

More information about the CGit mailing list