[PATCH v2 1/1] ui-ssdiff: ban strncat()

Christian Hesse list at eworm.de
Thu Feb 14 23:41:19 CET 2019

Eric Wong <e at 80x24.org> on Wed, 2019/02/13 08:29:
> Christian Hesse <list at eworm.de> wrote:
> > From: Christian Hesse <mail at eworm.de>
> > 
> > Git version v2.21.0 marks strncat() as banned (commit
> > ace5707a803eda0f1dde3d776dc3729d3bc7759a), so replace it.  
> Btw, I posted a similar-in-spirit patch to replace strncat
> in ui-ssdiff.c back in January: <20190102073710.580-1-e at 80x24.org>
> It uses strbuf and is close to code which already exists in
> git.git, so it doesn't make calls to strlen() repeatedly.
> (I'm also responsible for strncat banning in git.git :)

Ah, nice... I saw this but forgot about it. :-p

Jason, you are free to decide. ;)
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20190214/59a1a014/attachment.asc>

More information about the CGit mailing list