[pass] Importing tests

[Von Welch]

>
> It'd be nice if you could develop consistent style for $variable vs
> ${variable}, but for the most part, things look okay now.


I tend to use the brackets if I think it makes for easier-to-read code, but
it's fairly subjective and I don't feel strongly. Looks like you prefer the
first form unless you are using a modifier?

One thing I'd like to see in the harness is generating new gpg keys on the
> fly, but perhaps this is unnecessary.


I don't see the value off-hand, but don't see any reason why it couldn't be
done.

Another thing is I'd like to keep setup.sh fairly lean, and move any of
> those functions that aren't needed globally into the specific tests
> themselves. But for now, again, things seem fine.


Every function is used in multiple tests, or at least I envision it will be
once we have a full suite. In any case, I suggest waiting to do that
optimization until you have a complete suite.

Von

On Tue, Apr 22, 2014 at 12:36 PM, Jason A. Donenfeld <Jason at zx2c4.com>wrote:

> I've imported your tests here:
>
> http://git.zx2c4.com/password-store/commit/?id=760c644a1d9f55c91b74521b112958966e00ea31
>
> It'd be nice if you could develop consistent style for $variable vs
> ${variable}, but for the most part, things look okay now.
>
> One thing I'd like to see in the harness is generating new gpg keys on the
> fly, but perhaps this is unnecessary.
>
> Another thing is I'd like to keep setup.sh fairly lean, and move any of
> those functions that aren't needed globally into the specific tests
> themselves. But for now, again, things seem fine.
>
> Just a matter now of writing a full test suite. : )
>
>
> @LUKAS: feel free to go to town on the harness, playing with things,
> changing things, cleaning things up, etc...
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20140422/16facee2/attachment.html>