[PATCH] stop using pwgen

Jason A. Donenfeld Jason at zx2c4.com
Tue Dec 20 19:30:01 CET 2016


Hey Brian,

On Tue, Dec 20, 2016 at 11:30 AM, Brian Candler <b.candler at pobox.com> wrote:
> On 20/12/2016 10:17, Daniel Dörrhöfer wrote:
>
> I have tested this implementation with the -no-symbols / -n option
> turned on and have noticed that the password contains a single quote (').
>
> e.G. 7S3b4wJ4R7'RfWGagkhaM95'6
>
> To reproduce this, you have to generate a couple of passwords.
>
> Good catch :-)
>
> +CHARACTER_SET="${PASSWORD_STORE_CHARACTER_SET:-'[:graph:]'}"
> +CHARACTER_SET_NO_SYMBOLS="${PASSWORD_STORE_CHARACTER_SET_NO_SYMBOLS:-'[:alnum:]'}"
>
> has spurious quotes. Try changing to:
>
> +CHARACTER_SET="${PASSWORD_STORE_CHARACTER_SET:-[:graph:]}"
> +CHARACTER_SET_NO_SYMBOLS="${PASSWORD_STORE_CHARACTER_SET_NO_SYMBOLS:-[:alnum:]}"

Grrrrrr! Thanks, and nice catch.

Jason


More information about the Password-Store mailing list