password-store.el: can't edit password anymore

[Brice Waegenire]

Hi,

This is a follow up of this issue on Github
(https://github.com/NicolasPetton/pass/issues/8) where
"password-store-edit"
wasn't able to commit edit of a password to git which should be solved
in 1.0.0. However now I'm not able to use the
"password-store-edit" function anymore, I get the following error in
the "*Async shell command buffer*":
*ERROR*: Terminal type "dumb" is not powerful enough to run Emacs
Password unchanged.
And the "*Messages*" buffer get appended with:
/run/current-system/sw/bin/pass edit test: exited abnormally with code
1.
I'm using password-store.el 1.0.1 in emacs 25.3.1 with NixOS 17.03.

This issue seems to come from "with-editor", so I dug around a little
but I wasn't able to find the cause of the issue...
"with-editor-emacsclient-executable" is set to
"/nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/emacsclient"
which is the actual binary I use in my shell. And "with-editor-debug"
return this:
with-editor: /home/bricewge/.emacs.d/elpa/with-editor-20170817.1240/with-editor.el
emacs: /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/.emacs-wrapped
(25.3.1)
system:
  system-type: gnu/linux
  system-configuration: x86_64-pc-linux-gnu
  system-configuration-options: --disable-dependency-tracking
--prefix=/nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3
--with-modules --with-x-toolkit=gtk3 --with-xft
server:
  server-running-p: t
  server-process: #<process server24102>
  server-use-tcp: nil
  server-name: server24102
  server-socket-dir: /tmp/emacs3013
    pinentry
    server
    server24102
  server-auth-dir: ~/.emacs.d/server/
    WARNING: not an accessible directory
with-editor-emacsclient-executable:
 value:   /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/emacsclient
(25.3)
 default: /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/emacsclient
(25.3)
 funcall: /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/emacsclient
(25.3)
path:
  $PATH: "/home/bricewge/.zplug/repos/zplug/zplug/bin:/home/bricewge/.zplug/bin:/home/bricewge/.local/bin:/home/bricewge/bin:/run/wrappers/bin:/home/bricewge/.nix-profile/bin:/home/bricewge/.nix-profile/sbin:/home/bricewge/.nix-profile/lib/kde4/libexec:/nix/var/nix/profiles/default/bin:/nix/var/nix/profiles/default/sbin:/nix/var/nix/profiles/default/lib/kde4/libexec:/run/current-system/sw/bin:/run/current-system/sw/sbin:/run/current-system/sw/lib/kde4/libexec"
  exec-path: (/home/bricewge/.zplug/repos/zplug/zplug/bin/
/home/bricewge/.zplug/bin/ /home/bricewge/.local/bin/
/home/bricewge/bin/ /run/wrappers/bin/
/home/bricewge/.nix-profile/bin/ /home/bricewge/.nix-profile/sbin/
/home/bricewge/.nix-profile/lib/kde4/libexec/
/nix/var/nix/profiles/default/bin/ /nix/var/nix/profiles/default/sbin/
/nix/var/nix/profiles/default/lib/kde4/libexec/
/run/current-system/sw/bin/ /run/current-system/sw/sbin/
/run/current-system/sw/lib/kde4/libexec/
/nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/libexec/emacs/25.3/x86_64-pc-linux-gnu/)
  with-editor-emacsclient-path:
    /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin (t)
      /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/.emacsclient-wrapped
(25.3)
      /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/bin/emacsclient
(25.3)
    /home/bricewge/.zplug/repos/zplug/zplug/bin/ (t)
    /home/bricewge/.zplug/bin/ (t)
    /home/bricewge/.local/bin/ (t)
    /home/bricewge/bin/ (nil)
    /run/wrappers/bin/ (t)
    /home/bricewge/.nix-profile/bin/ (t)
    /home/bricewge/.nix-profile/sbin/ (t)
    /home/bricewge/.nix-profile/lib/kde4/libexec/ (nil)
    /nix/var/nix/profiles/default/bin/ (t)
    /nix/var/nix/profiles/default/sbin/ (t)
    /nix/var/nix/profiles/default/lib/kde4/libexec/ (nil)
    /run/current-system/sw/bin/ (t)
      /run/current-system/sw/bin/.emacsclient-wrapped (25.3)
      /run/current-system/sw/bin/emacsclient (25.3)
    /run/current-system/sw/sbin/ (t)
    /run/current-system/sw/lib/kde4/libexec/ (nil)
    /nix/store/llhhf958v68zhcvb6hyh538jv46fnrm2-emacs-25.3/libexec/emacs/25.3/x86_64-pc-linux-gnu/
(nil)


Thanks for your awesome work on this password manager!
Brice Waegeneire.