[PATCH] Don’t include $EDITOR command in commit message

Amir Yalon quoiceehoh-20180826 at yxejamir.net
Sun Aug 26 22:57:45 CEST 2018

This bit of information is not relevant to the history of the password.
 src/password-store.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


This has been a personal itch for me ever since I switched to using emacsclient
as default editor. Some context behind the desire to apply the patch: in my
workflow, the $EDITOR variable is different for each project I work on, but I
might invoke `pass` from any open session. When later viewing `pass git log`,
being able to tell which session invoked `pass` is irrelevant and distracting.

Thanks for an awesome tool!


diff --git a/src/password-store.sh b/src/password-store.sh
index d89d455..e9b84e5 100755
--- a/src/password-store.sh
+++ b/src/password-store.sh
@@ -487,7 +487,7 @@ cmd_edit() {
 	while ! $GPG -e "${GPG_RECIPIENT_ARGS[@]}" -o "$passfile" "${GPG_OPTS[@]}" "$tmp_file"; do
 		yesno "GPG encryption failed. Would you like to try again?"
-	git_add_file "$passfile" "$action password for $path using ${EDITOR:-vi}."
+	git_add_file "$passfile" "$action password for $path using editor."
 cmd_generate() {

More information about the Password-Store mailing list