[PATCH] Do not set foreground color for generated password

Lukas Fleischer lfleischer at lfos.de
Thu Jul 26 19:56:40 CEST 2018

Since commit 63ef32a (generate: use nice ansi colors instead.,
2014-05-08), generated passwords are highlighted to make them
distinguishable from the Git output.

However, setting the foreground color to white makes the password hardly
readable when a "black on white" color scheme is used. Drop the
hardcoded foreground color and use the bold attribute only instead.

Signed-off-by: Lukas Fleischer <lfleischer at lfos.de>
This has been bugging me for quite a while. Using a bold font should
suffice to make the message stand out...

 src/password-store.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/password-store.sh b/src/password-store.sh
index 715dc93..55a1aea 100755
--- a/src/password-store.sh
+++ b/src/password-store.sh
@@ -538,7 +538,7 @@ cmd_generate() {
 	elif [[ $qrcode -eq 1 ]]; then
 		qrcode "$pass" "$path"
-		printf "\e[1m\e[37mThe generated password for \e[4m%s\e[24m is:\e[0m\n\e[1m\e[93m%s\e[0m\n" "$path" "$pass"
+		printf "\e[1mThe generated password for \e[4m%s\e[24m is:\e[0m\n\e[1m\e[93m%s\e[0m\n" "$path" "$pass"

More information about the Password-Store mailing list