DEFAULT_GROUP for contrib/importers/lastpass2pass.rb

Amir Yalon quoiceehoh-20180826 at yxejamir.net
Wed Oct 9 07:21:05 CEST 2019


On Tue, Oct 8, 2019, at 17:32, Devin Smith wrote:
> - grouping = DEFAULT_GROUP if grouping == nil
> + grouping = DEFAULT_GROUP if grouping.empty?

> Although - it looks like this line was intentionally changed https://git.zx2c4.com/password-store/commit/contrib/importers/lastpass2pass.rb?id=85757e99bff29d6fa663a6b291c9047ccce8c6d3.
> 
> I'm not familiar with ruby, but here is my version:

To cover both the nil and empty string cases, one might check for `grouping.to_s.empty?`.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20191009/110cc88c/attachment.html>


More information about the Password-Store mailing list