[PATCH] Honour the $VISUAL environment variable

pudinha rogi at skylittlesystem.org
Tue Aug 4 13:20:39 CEST 2020


> > I mean, strictly speaking, if pass were to use both VISUAL and EDITOR,
> > it should check that it is running in a terminal, and only then, call
> > VISUAL, otherwise call EDITOR. But I think the de facto standard today
> > is for people to just set EDITOR to a “visual” editor, as teletypes
> > are a thing of the past.
>
> I think it depends on whether we want to support old terminals or just
> the variables. I've seen it implemented like that in a few places, but
> I've also seen others doing the terminal check.
>
> My patch is just about the variables, as I didn't want to change them
> just because of pass, or have a wrapper script in ~/bin/pass, like I
> do now, setting `EDITOR=$VISUAL`.

Hello password storers!

Any thoughts on that patch? Do you want me to implement the terminal check?

Please, let me know.
Best regards,

-- 
pudinha (she/her)


More information about the Password-Store mailing list