[PATCH v2 2/2] Support bemenu under wayland

Daniel pass at 0xdc.io
Fri Mar 13 11:07:08 CET 2020

On Mon, Feb 24, 2020 at 01:10:38PM +0000, Daniel wrote:
> On Sat, Feb 22, 2020 at 03:19:07PM +0100, password-store at storiepvtride.it wrote:
> > Am 17.02.20 um 14:49 schrieb Daniel Cordero:
> > > In a resized/scaled wayland display, dmenu running under Xwayland can
> > > look blurry.
> > > 
> > > On wayland, use a wayland-native menu program if it is available.
> > > Otherwise, continue using dmenu.
> > 
> > Would it make sense to also add "dmenu-wl" to the list of supported
> > Wayland native applications for this?
> > 
> > https://github.com/nyyManni/dmenu-wayland
> > 
> Honestly I don't have a list of compatible menus that I could use, so I
> just did the one that I use.
> I did plan to have it possible to define a list of working menu systems
> and for passmenu be able to test and use them, but I think I have another
> idea to just take an argument so that it could be used for any program.
> I'll re-work the patch.

So I had a look at how passmenu handles command-line arguments, and,
umm well, it doesn't. Which means that adding any type of change here
might break people's current setups.

Currently, passmenu takes arguments in the form:

  passmenu [--type] [<dmenu args>...]

I want to add a --dmenu="" option, but this could be placed before,
after, or instead of the --type flag; and passmenu will still need to ignore
any dmenu args:

  passmenu --dmenu="dmenu-wl" --type <dmenu_args>
  passmenu --type --dmenu="bemenu" <dmenu_args>
  passmenu --dmenu="dmenu" <dmenu_args>

Should I add a marker that differentiates the passmenu args from
the dmenu args, to make it more uniform?

  passmenu <passmenu_args> -- <dmenu_args>

Perhaps put in a deprecation notice and stage patches for future
releases to avoid changing this suddenly?

More information about the Password-Store mailing list