[PATCH v2 2/2] Support bemenu under wayland

[Gamma]

On 2020-03-13 05:07, Daniel wrote:
> On Mon, Feb 24, 2020 at 01:10:38PM +0000, Daniel wrote:
>> On Sat, Feb 22, 2020 at 03:19:07PM +0100, password-store at storiepvtride.it wrote:
>>> Am 17.02.20 um 14:49 schrieb Daniel Cordero:
>>>> In a resized/scaled wayland display, dmenu running under Xwayland can
>>>> look blurry.
>>>>
>>>> On wayland, use a wayland-native menu program if it is available.
>>>> Otherwise, continue using dmenu.
>>>
>>> Would it make sense to also add "dmenu-wl" to the list of supported
>>> Wayland native applications for this?
>>
>> Honestly I don't have a list of compatible menus that I could use, so I
>> just did the one that I use.
>>
>> I did plan to have it possible to define a list of working menu systems
>> and for passmenu be able to test and use them, but I think I have another
>> idea to just take an argument so that it could be used for any program.
> 
> So I had a look at how passmenu handles command-line arguments, and,
> umm well, it doesn't. Which means that adding any type of change here
> might break people's current setups.
> 
> Currently, passmenu takes arguments in the form:
> 
>   passmenu [--type] [<dmenu args>...]
> 
> I want to add a --dmenu="" option, but this could be placed before,
> after, or instead of the --type flag; and passmenu will still need to ignore
> any dmenu args:
> 
>   passmenu --dmenu="dmenu-wl" --type <dmenu_args>
>   passmenu --type --dmenu="bemenu" <dmenu_args>
>   passmenu --dmenu="dmenu" <dmenu_args>
> 
> Should I add a marker that differentiates the passmenu args from
> the dmenu args, to make it more uniform?
> 
>   passmenu <passmenu_args> -- <dmenu_args>
> 
> Perhaps put in a deprecation notice and stage patches for future
> releases to avoid changing this suddenly
I imagine most users of passmenu use it without arguments since "it just
works", so testing for various menus may be the right way to go. I
attached a patch; it adds the menus mentioned so far in the thread as
well as 'rofi' and 'wofi' using IFS splitting. I've been using my own
version of passmenu for rofi and wofi for a long time, since I prefer
them to dmenu.

Additionally if the user wants another menu, they can specify

    DMENU='some-program' passmenu

The second patch uses ydotool on wayland so --type will work.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Test-for-compatible-menus.patch
Type: text/x-patch
Size: 1297 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20200313/fd0ae5f4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Support-wayland-type-with-ydotool.patch
Type: text/x-patch
Size: 792 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20200313/fd0ae5f4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20200313/fd0ae5f4/attachment.asc>