`pass git` exit code

Rob robpilling at gmail.com
Tue Sep 29 14:35:03 CEST 2020


Is there anything I can do to help get this merged? I'm bitten
occasionally by git fetch failing and pass ignoring the failure.

On Sun, 28 Jun 2020 at 17:41, <robpilling at gmail.com> wrote:
>
> On Thu, 25 Jun 2020, Kjetil Torgrim Homme wrote:
> > On 6/24/20 10:23 PM, robpilling at gmail.com wrote:
> >> That's a fair point - my main reason for doing it this way was that I
> >> imagined exiting with the same code as the git command would be more
> >> useful, so users can treat `pass git [...]` as a transparent wrapper,
> >> particularly for commands that specify specific exit codes. Happy to
> >> change it if people would prefer the consistent use of die() / exit code
> >> of 1.
> >
> > I would prefer to keep the information from git exit codes intact as
> > well, but this should be documented in the manual page.  I see there is
> > no EXIT CODES section today, so there isn't really any documented
> > behaviour to break.
>
> Cool - documentation added, also removed two odd-one-out cases of $?.
>
> Thanks,
> Rob


More information about the Password-Store mailing list