making wireguard work on RHEL7/etc.

[wireguard at wut.to]

Andrej Kacian wrote:

> On Mon, 26 Jun 2017 11:57:56 +0200
> "Jason A. Donenfeld" <Jason at zx2c4.com> wrote:
>
> > Excellent!
> >
> > Indeed let's roll with that. Perhaps something quite specific, though,
> > like:
> >
> > #if RHEL_RELEASE_CODE <= RHEL_RELEASE_VERSION(7,3)
> >
> > If you want to reroll your patches around this, in a really clean way,
> > and submit them using git-send-email to the list, I can do a proper
> > review and we can get this merged.
>
> I wonder - is it a good idea to depend on
> nonstandard, distribution-specific defines like this? This kind of
> modification IMHO belongs in a local patch applied during a rpmbuild
> for a RHEL/Centos package.

I think that depends entirely on if you want it to be easy for users to
obtain and use your software. If it requires constant patching and
updates, most people won't bother and will use something else.

The issue for me was that I couldn't just install the software and use it,
I had to figure out how to access the RPM repo (RedHat 7 and the like do
not support dnf/Copr out of the box) I then had to figure out how DKMS was
working (you just get a RPM script error on install), spend time
commenting out random defines in a set of source I don't understand. As
soon as the RPM self-updates this will break and I'll have to do it all
again.

If you have no interest in support RedHat/CentoS/Sceintific Linux/etc.
then it might be worth not publishing RPMs that claim to work with it (and
don't). If you do have interest in it, I would strongly suggest making it
Actually Work.