[PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

Miguel Ojeda miguel.ojeda.sandonis at gmail.com
Wed Dec 2 13:50:30 CET 2020

On Sat, Nov 28, 2020 at 8:34 PM Masahiro Yamada <masahiroy at kernel.org> wrote:
> Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK").
> A lot of warn_unused_result warnings existed in 2006, but until now
> they have been fixed thanks to people doing allmodconfig tests.
> Our goal is to always enable __must_check where appropriate, so this
> CONFIG option is no longer needed.
> I see a lot of defconfig (arch/*/configs/*_defconfig) files having:
>     # CONFIG_ENABLE_MUST_CHECK is not set
> I did not touch them for now since it would be a big churn. If arch
> maintainers want to clean them up, please go ahead.
> While I was here, I also moved __must_check to compiler_attributes.h
> from compiler_types.h
> Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
> Acked-by: Jason A. Donenfeld <Jason at zx2c4.com>

Picked this new version with the Acks etc., plus I moved it within
compiler_attributes.h to keep it sorted (it's sorted by the second
column, rather than the first).

Thanks a lot!


More information about the WireGuard mailing list