[pass] pass in cygwin

[Brandon Jones]

On Thu, Apr 17, 2014 at 10:45 AM, Jason A. Donenfeld <Jason at zx2c4.com>wrote:

>
> On Apr 17, 2014 4:31 PM, "Brandon Jones" <jones.brandon.lee at gmail.com>
> wrote:
> >
> > Hi Jason,
>
> Please remember to keep the list CCd.
>
I was not aware you included a list. I'll be sure to hit reply-all now.

> >
> > Manually changing the function worked, so that's all good.
>
> Do NOT manually change the function. Do not modify /usr/bin/pass or
> src/password-store.sh. Instead ONLY modify src/platform/cygwin.sh. This is
> the location of the functions for cygwin. If you make adjustments to it,
> send a diff to the mailing list. This way, everyone benefits. Let me know
> if any part of that isn't clear.
>

The only thing that was unclear is the part where you say "verify this
works, as well as the makefile." The statement implies that one should
verify that the function works but not by any specific method. My apologies
for choosing to do this by modifying the function within the /usr/bin/pass
rather than modifying src/platform/cygwin.sh to call the function clip with
two dummy variables. It didn't occur to me that it would matter either way.
I've not been involved in any programming projects with others nor do I
primarily use git or bash (for scripting I use python) so you'll have to
take that into account.


>  > However I do get an error on "make install"
> >
> > make install
> > removed `/usr/bin/pass'
> > `src/password-store.sh' -> `/usr/bin/pass'
> > removed `/usr/share/man/man1/pass.1'
> > `man/pass.1' -> `/usr/share/man/man1/pass.1'
> > removed `/usr/share/bash-completion/completions/pass'
> > `src/completion/pass.bash-completion' ->
> `/usr/share/bash-completion/completions/pass'
> > `src/platform/cygwin.sh' -> `/usr/lib/password-store.platform.sh'
> > sed -i "" 's:.*platform-defined-functions.*:source /usr/lib/
> password-store.platform.sh:' "/usr/bin/pass"
> > sed: can't read s:.*platform-defined-functions.*:source /usr/lib/
> password-store.platform.sh:: No such file or directory
> > Makefile:28: recipe for target 'install' failed
> > make: *** [install] Error 2
>
> I've fixed this now; thanks for reporting it. Git pull and try again...
>

Getting git-pull to work in Cygwin is/can be a pain. I manually downloaded
the zip file. It still did not work.

 $make install
> `src/password-store.sh' -> `/usr/bin/pass'
> `man/pass.1' -> `/usr/share/man/man1/pass.1'
> removed `/usr/share/bash-completion/completions/pass'
> `src/completion/pass.bash-completion' ->
> `/usr/share/bash-completion/completions/pass'
> `src/platform/cygwin.sh' -> `/usr/lib/password-store.platform.sh'
> sed -i "" 's:.*platform-defined-functions.*:source /usr/lib/
> password-store.platform.sh:' "/usr/bin/pass"
> sed: can't read s:.*platform-defined-functions.*:source /usr/lib/
> password-store.platform.sh:: No such file or directory
> Makefile:28: recipe for target 'install' failed
> make: *** [install] Error 2



For what it's worth, the file does exist:

04/17/14 11:38 AM #####@#####  ~/password-store
> $make uninstall
> removed `/usr/bin/pass'
> removed `/usr/share/man/man1/pass.1'
> removed `/usr/lib/password-store.platform.sh'
>


04/17/14 11:39 AM #####@#####  ~/password-store
> $make install
> `src/password-store.sh' -> `/usr/bin/pass'
> `man/pass.1' -> `/usr/share/man/man1/pass.1'
> removed `/usr/share/bash-completion/completions/pass'
> `src/completion/pass.bash-completion' ->
> `/usr/share/bash-completion/completions/pass'
> `src/platform/cygwin.sh' -> `/usr/lib/password-store.platform.sh'
> sed -i "" 's:.*platform-defined-functions.*:source /usr/lib/
> password-store.platform.sh:' "/usr/bin/pass"
> sed: can't read s:.*platform-defined-functions.*:source /usr/lib/
> password-store.platform.sh:: No such file or directory
> Makefile:28: recipe for target 'install' failed
> make: *** [install] Error 2
>


04/17/14 11:39 AM #####@#####  ~/password-store
> $ls -l /usr/lib/password-store.platform.sh
> -rw-r--r-- 1 ##### Domain Users 668 Apr 17 11:39 /usr/lib/
> password-store.platform.sh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20140417/0628d330/attachment.html>