[pass] Possible improvements

[Dashamir Hoxha]

On Mon, Jan 25, 2016 at 8:29 PM, Matthew Monaco <matt at monaco.cx> wrote:

> On 01/25/2016 12:16 PM, Dashamir Hoxha wrote:
> >
> >
> > On Mon, Jan 25, 2016 at 8:01 PM, Lenz Weber <mail at lenzw.de
> > <mailto:mail at lenzw.de>> wrote:
> >
> >     I'm not 100% but what you are doing will most likely split up
> GPG_OPTS that
> >     contain spaces into multiple options. If you want to go that way,
> use functions.
> >
> >
> > I think that functions in bash cannot return values (except a return
> status: 0,
> > 1, etc.)
> > GPG options that contain spaces?! This sounds weird. We can check the
> manual
> > of GPG about it.
> >
> >
>
> Anything on stderr/stdout is a "returned value" in the same sense that the
> existing commands work.
>
> gpg doesn't have option names with spaces, but the arguments certainly
> can. You
>

You are right, arguments can have.

But, from the man page:
"*PASSWORD_STORE_GPG_OPTS: *Additional options to be passed to all
invocations of GPG."
It does not say that it is an array. And if it is a string, then there are
no problems
inside the script.


> need to be careful to preserve them, and arrays in bash are the best way.
> RE
> your other email: "${var[@]}" is perfectly good bash, similar to "$@" but
> it
> only works when written just like that, you can't embed the expansion in a
> longer string. So if you try to use aliases you'll likely have the same
> syntactical issue.
>
> >
> >     Regards,
> >     Lenz
> >
> >     Am 25.01.2016 um 19:45 schrieb Dashamir Hoxha:
> >>     I see that `pass` is more advanced than what I initially thought.
> >>     It allows several people to have access to passwords, and they
> >>     all can synchronize through git.
> >>
> >>     So, replacing asymmetric encryption with symmetric encription
> >>     is not an option. However I still think that *both* of them can be
> supported,
> >>     and the user can choose which one is more suitable for him.
> >>     And actually this will not make the script more complicated,
> >>     but hopefully simpler.
> >>
> >>     I have already started to work on it. The first step was to factor
> out
> >>     the encrypt and decript commands:
> >>
> https://github.com/dashohoxha/password-store/commit/af32b5c8c863a3245b6a3bd752f503f768033361
> >>     Please check it out, for code review and to make sure that
> >>     I am not missing something.
> >>
> >>     Thanks,
> >>     Dashamir
> >>
> >>     On Sun, Jan 24, 2016 at 9:36 PM, Lenz Weber <mail at lenzw.de
> >>     <mailto:mail at lenzw.de>> wrote:
> >>
> >>         Or you use two different keys for a directory.
> >>
> >>
> >>         pass init -p subdir keyid1 keyid2
> >>
> >>         now both people can read it
> >>
> >>         Am 24.01.2016 um 21:04 schrieb Christoph Egger:
> >>         > Hi!
> >>         >
> >>         > Aleksandr Pasechnik <al at megamicron.net <mailto:
> al at megamicron.net>>
> >>         writes:
> >>         >> How does the key sharing work?
> >>         >
> >>         > You can use a different, shared key for some subdirectories
> >>         > We're doing this a lot here
> >>         >
> >>         >   Christoph
> >>         > _______________________________________________
> >>         > Password-Store mailing list
> >>         > Password-Store at lists.zx2c4.com <mailto:
> Password-Store at lists.zx2c4.com>
> >>         > http://lists.zx2c4.com/mailman/listinfo/password-store
> >>         >
> >>         _______________________________________________
> >>         Password-Store mailing list
> >>         Password-Store at lists.zx2c4.com <mailto:
> Password-Store at lists.zx2c4.com>
> >>         http://lists.zx2c4.com/mailman/listinfo/password-store
> >>
> >>
> >
> >
> >
> >
> > _______________________________________________
> > Password-Store mailing list
> > Password-Store at lists.zx2c4.com
> > http://lists.zx2c4.com/mailman/listinfo/password-store
> >
>
> _______________________________________________
> Password-Store mailing list
> Password-Store at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/password-store
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/password-store/attachments/20160126/a3fe4996/attachment-0001.html>